Problem/Motivation

Follow up issue after #3252219: Add Container wrapper ID field to the advanced section settings tab

Warning: Undefined array key "container_wrapper_id" in Drupal\varbase_layout_builder\Plugin\Layout\VarbaseLayoutBuilderBootstrapLayout->buildConfigurationForm() (line 504 of /app/docroot/modules/contrib/varbase_layout_builder/src/Plugin/Layout/VarbaseLayoutBuilderBootstrapLayout.php) #0 /app/docroot/core/includes/bootstrap.inc(346): _drupal_error_handler_real(2, 'Undefined array...', '/app/docroot/mo...', 504)

Proposed resolution

Use the parent::defaultConfiguration and the defaultConfiguration to reset the value for the Container wrapper ID

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, varbase_layout_builder-10.0.20

Varbase update type:

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • Issue #3266114 by abu-zakham: Fixed warnings as a follow up issue after added Container wrapper ID field to the advanced section settings tab
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

abu-zakham created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Status: Active » Needs review
ahmad abbad’s picture

Patch #2 worked for me

rajab natshah’s picture

Version: 10.1.x-dev » 10.0.x-dev

  • Rajab Natshah committed f206b12 on 10.0.x
    Issue #3266114 by abu-zakham: Fix warnings as a follow up issue after...

  • Rajab Natshah committed 0a065fb on 10.1.x
    Issue #3266114 by abu-zakham: Fix warnings as a follow up issue after...
rajab natshah’s picture

Issue summary: View changes

Thanks @abu-zakham
Your logic is better on this
Using the parent::defaultConfiguration and the defaultConfiguration
Some of the default Configurations could be moved to the defaultConfiguration method

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.0.9, +varbase_layout_builder-10.0.20
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9