Problem/Motivation
Adding attributes from settings tab by writing YAML on attributes field is kind of confusing for non technical users
Steps to reproduce
Given that we need to link sections to get to them from any place
When trying to add id attribute to a section we have to add it as YAML syntax
Then there is no easier way to add an id attribute to the section
Proposed resolution
To add a field for the id attribute to be filled without using YAML since id is the most likely to be used by a non-technical user
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release varbase-9.0.5, varbase_layout_builder-10.0.10
Varbase update type:
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
API changes
- N/A
Data model changes
The section will save extra container_wrapper_id value in the section sync settings
Issue fork varbase_layout_builder-3252219
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments
Comment #2
hanii.gerges commentedComment #3
rajab natshahComment #4
hanii.gerges commentedComment #5
hanii.gerges commentedComment #6
rajab natshahComment #7
rajab natshahI agree, that this is needed in number of cases
Reviewing with the product owner
Comment #8
rajab natshahComment #9
hanii.gerges commentedComment #10
hanii.gerges commentedComment #11
rajab natshahVery good idea to have:
Comment #12
hanii.gerges commentedAn update to the original patch to add description to the field and validate field value.
Comment #13
hanii.gerges commentedComment #14
hanii.gerges commentedComment #15
rajab natshahFeedback by Razem
Comment #16
hanii.gerges commentedChanged the location of the field to be in container settings
Comment #17
hanii.gerges commentedComment #18
hanii.gerges commentedComment #19
rajab natshahComment #20
rajab natshahComment #21
rajab natshahComment #22
rajab natshahFeedback by Razem
Comment #23
rajab natshahComment #24
rajab natshahComment #25
rajab natshahComment #26
rajab natshahComment #28
hanii.gerges commentedLabel changed to "Container wrapper ID"
Comment #29
rajab natshahComment #30
rajab natshahComment #31
rajab natshahComment #33
rajab natshahComment #34
rajab natshahComment #35
rajab natshahComment #36
rajab natshahComment #37
rajab natshahComment #38
rajab natshahComment #41
abu-zakham commentedI've noticed that a new warn starts appearing in the logs, a new pull request has been created to fix the issue.
Warning: Undefined array key "container_wrapper_id" in Drupal\varbase_layout_builder\Plugin\Layout\VarbaseLayoutBuilderBootstrapLayout->buildConfigurationForm() (line 504 of /app/docroot/modules/contrib/varbase_layout_builder/src/Plugin/Layout/VarbaseLayoutBuilderBootstrapLayout.php) #0 /app/docroot/core/includes/bootstrap.inc(346): _drupal_error_handler_real(2, 'Undefined array...', '/app/docroot/mo...', 504)Comment #42
rajab natshahThanks abu-zakham for following up on issues :)
This issue was fixed and released
Varbase Layout Builder 10.0.10
https://www.drupal.org/project/varbase_layout_builder/releases/10.0.10
Please file a follow up issue for it.
The title could be:
"Fix warnings as a follow up issue after added Container wrapper ID field to the advanced section settings tab"
Comment #43
rajab natshahComment #45
rajab natshah#3266114: Fix warnings as a follow up issue after added Container wrapper ID field to the advanced section settings tab