Problem/Motivation

Adding attributes from settings tab by writing YAML on attributes field is kind of confusing for non technical users

Steps to reproduce

Given that we need to link sections to get to them from any place
When trying to add id attribute to a section we have to add it as YAML syntax
Then there is no easier way to add an id attribute to the section

Proposed resolution

To add a field for the id attribute to be filled without using YAML since id is the most likely to be used by a non-technical user

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release varbase-9.0.5, varbase_layout_builder-10.0.10

Varbase update type:

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Screenshot Add Container wrapper ID field to the advanced section settings tab

API changes

  • N/A

Data model changes

The section will save extra container_wrapper_id value in the section sync settings

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

hanii.gerges created an issue. See original summary.

hanii.gerges’s picture

StatusFileSize
new1.86 KB
rajab natshah’s picture

Status: Active » Needs review
hanii.gerges’s picture

Issue summary: View changes
hanii.gerges’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem

I agree, that this is needed in number of cases
Reviewing with the product owner

rajab natshah’s picture

Issue summary: View changes
hanii.gerges’s picture

hanii.gerges’s picture

rajab natshah’s picture

Very good idea to have:

hanii.gerges’s picture

An update to the original patch to add description to the field and validate field value.

hanii.gerges’s picture

hanii.gerges’s picture

StatusFileSize
new2.33 KB
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Needs work

Feedback by Razem

  • Nice to have
  • Locate it in the Container Settings field group
  • Follow the same style and prefix with validation
hanii.gerges’s picture

Changed the location of the field to be in container settings

hanii.gerges’s picture

Status: Needs work » Needs review
hanii.gerges’s picture

Issue summary: View changes
StatusFileSize
new32.71 KB
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah’s picture

Feedback by Razem

rajab natshah’s picture

Status: Needs review » Needs work
rajab natshah’s picture

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

hanii.gerges’s picture

Label changed to "Container wrapper ID"

rajab natshah’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Title: Add section id field to settings tab » Add Container wrapper ID field to section advanced container settings tab
rajab natshah’s picture

Title: Add Container wrapper ID field to section advanced container settings tab » Add Container wrapper ID field to the advanced section settings tab

rajab natshah’s picture

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.0.5, +varbase_layout_builder-10.0.10
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

abu-zakham made their first commit to this issue’s fork.

abu-zakham’s picture

Status: Fixed » Needs review

I've noticed that a new warn starts appearing in the logs, a new pull request has been created to fix the issue.

Warning: Undefined array key "container_wrapper_id" in Drupal\varbase_layout_builder\Plugin\Layout\VarbaseLayoutBuilderBootstrapLayout->buildConfigurationForm() (line 504 of /app/docroot/modules/contrib/varbase_layout_builder/src/Plugin/Layout/VarbaseLayoutBuilderBootstrapLayout.php) #0 /app/docroot/core/includes/bootstrap.inc(346): _drupal_error_handler_real(2, 'Undefined array...', '/app/docroot/mo...', 504)

rajab natshah’s picture

Status: Needs review » Fixed

Thanks abu-zakham for following up on issues :)

This issue was fixed and released
Varbase Layout Builder 10.0.10
https://www.drupal.org/project/varbase_layout_builder/releases/10.0.10

Please file a follow up issue for it.
The title could be:
"Fix warnings as a follow up issue after added Container wrapper ID field to the advanced section settings tab"

rajab natshah’s picture

Status: Fixed » Closed (fixed)