Move non-migration tests to Forum in preparation for deprecation

Thanks for the issue. I've updated the title and issue summary with typo fixes and minor wording and formatting changes.

Thanks for the patch @joshua1234511. Are you going to continue to work on this?

Thanks for updating the title @apaderno. My understanding from the Drupal 10 Readiness team is that we don't need to tag with Drupal 10 if the branch is 10.0.x-dev but I'll leave it since maybe you are using it for something.

Unfortunately this is currently being worked on here as well:

https://www.drupal.org/project/drupal/issues/3261653#comment-14414137

so please hold off until I understand what's going on.

Okay... so... here's the scoop:

1. @quietone was doing a proof of concept in #3261653: Remove Forum module for dealing with migration tests.

2. This issue is fine for moving everything except for migration tests for now.

3. Tests may fail here and, if so, you can look at the MR in #3261653: Remove Forum module to see how that's trying to decouple migration and forum.

For additional details, you can look at this Slack thread: https://drupal.slack.com/archives/C014CT1CN1M/p1645065441717149

Carry on :)

Carry on for real.

To make up for the confusion I've merged in the test changes I made over in the other issue to here.

At minimum, the migrate_drupal_ui functional tests need to be changed, which should pass tests now. There may be few other tests that need to be changed. I have to double check.

The extensive removal of forum from migration tests throughout core, outside of migrate_drupal_ui, is probably not necessary. The test fixtures do contain forum data and we should continue to test what happens when various migrations run with that data. However, the migrate maintainers haven't has a chance to discuss how to manage migrations and the tests when a module is moved to contrib. The next meeting is in a few hours but I should be asleep for this one.

Oh, I am only working on the migration tests here, others should continue to work on any other test.

@Kristen I apologize: I saw it on other issues for Drupal 10 where Version is already set to 10.0.x-dev, and I thought it was necessary. If it shouldn't be used, there is no need to keep it. I am not using for my purposes.

Version of the migrate_drupal_ui functional tests (*ReviewPageTests and Upgrade) needs to be created in forum.

@apaderno I found out that some of the core maintainers do use the Drupal 10 tag even though the version is 10.0.x-dev while others do not so no harm leaving it. :)

MR needs rebase and it looks mostly near

Added a patch for Drupal 10.0.x.

Merged 10.0.x back into the merge request, so I'm hiding the patch in #17. Let's just continue with the merge request. :)

Removed all the migration changes so they can be done in a separate test.

The failing test was InstallUninstallTest. This tests that all modules can be installed and uninstalled. However, deprecated modules are excluded from the list of all modules so I think that the forum specific code should be removed when Forum is marked deprecated. For, now I have added @todo statements.

DependencyTest - This is testing core functionality of install and uninstall so I don't think that a forum specific version is needed. However, I have left the forum version in the MR in case that is wrong.

Left a review, thanks for working on this

Updated the MR and replied, so setting back to NR.

Looks good to me, I agree, the existing coverage of path processing for /user is sufficient.

Thank you for working on this 💙

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rebased and tests passing, restoring RTBC

The MR doesn't apply to 10.1.x, following #3339770: Remove dead class PathProcessor in url_alter_test module where core/modules/system/tests/modules/url_alter_test/src/PathProcessor.php was removed.

The MR should be rebased or recreated against 10.1.x and the change to that file removed.

Once again, GitLab has decided I can't push, after just pushing. Therefore, here is a patch.

Applied patch #29 and did a search for 'forum'.

All the instances I found (outside Forum module) were in migrate code. Assuming that is fine.

Removing credit for @ravi.shankar as this is 10.1.x only so a 10.0.x patch isn't needed.

Committed to 10.1.x and pushed, thanks!