Business Rules 2.0.0-beta2 release plan D10 compatible [#3261552]

Updates

Merged all patches into a merge request and added the D10 compatibility fixes.

Problem/Motivation

The intent of this issue is to help the maintainer(s) coordinate community efforts in the creation of a stable release. Community involvement is only intended as a suggestion; it is up to maintainers to ultimately decide the creation of, and what goes into, a stable release. If you are not interested in using this issue, please mark the issue as Fixed or Closed (works as designed).

There are many benefits to publishing a stable release for a module.

Release-blocker issues

Good-to-fix issues

"Issue #3095392: How to add value to multi-value field without loosing existing values?"

Above and beyond tasks

Create issue fix list for stable release using the grn tool.

Remaining tasks

Establish a list of release-blockers and 'good-to-fix' issues for a stable release.
Resolve above issues blocking the release of a stable release.
Craft changelog for new release.
Create new release.

Do you have resources you'd like to contribute to this template? Have feedback on the stable release request issue template? We want your feedback: #3239062: 'Stable Release Request' Issue Template

Original issue summary

Problem/Motivation

@colan, would it be possible to commit some patches to --dev and possibly in the feature tag a 2.0.0-beta2 release? Thanks for considering.

Proposed resolution

This is what I use in production now. We can add more to this list.

Issue fork business_rules-3261552

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3261552-business-rules-2.0.0-beta2 changes, plain diff MR !15
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

31 January 2022 at 14:29

lexsoft created an issue. See original summary.

Comment #2

lexsoft commented 31 January 2022 at 14:30

Issue summary:

View changes

Comment #3

lexsoft commented 31 January 2022 at 14:31

Issue summary:

View changes

Comment #4

Duvan.Slabbert commented 1 February 2022 at 17:09

+1 on this. I think its time to put some pressure on getting this done.

Comment #5

kazah commented 2 February 2022 at 11:33

+1 for this update

Comment #6

Webbeh

he/him/his

Georgia, USA

commented 3 February 2022 at 13:30

Title:	Plan for Business Rules 2.0.0-beta2 release	» Business Rules 2.0.0-beta2 release plan
Issue summary:	View changes

Comment #7

Duvan.Slabbert commented 3 February 2022 at 13:55

I would also like to add the following to the list of things i needed to do as well.

https://www.drupal.org/project/drupal/issues/3180227#comment-13890098
https://www.drupal.org/project/business_rules/issues/2998984#comment-131...
https://www.drupal.org/project/business_rules/issues/3067571#comment-135...

Comment #8

lexsoft commented 6 April 2022 at 12:15

Issue summary:

View changes

Comment #9

lexsoft commented 11 April 2022 at 15:45

Issue summary:

View changes

Comment #10

lexsoft commented 11 April 2022 at 15:51

Issue summary:

View changes

Comment #11

lexsoft commented 12 April 2022 at 08:55

Issue summary:

View changes

Comment #12

lexsoft commented 12 April 2022 at 10:28

Issue summary:

View changes

Comment #13

lexsoft commented 17 April 2023 at 09:20

Status:

Active

» Needs review

Comment #14

1 November 2023 at 09:05

lexsoft opened merge request !15

Comment #15

lexsoft commented 1 November 2023 at 09:08

Title:	Business Rules 2.0.0-beta2 release plan	» Business Rules 2.0.0-beta2 release plan D10 compatible
Version:	2.0.0-beta1	» 2.x-dev
Issue summary:	View changes

Comment #16

lexsoft commented 1 November 2023 at 09:09

Comment #17

18 December 2023 at 12:01

rcodina made their first commit to this issue’s fork.

Comment #18

rcodina

Catalan

Barcelona

commented 18 December 2023 at 12:03

I've just fixed the following error reported to me by upgrade_status module after applying MR patch.

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

Comment #19

rcodina

Catalan

Barcelona

commented 28 December 2023 at 11:47

Just fixed the following error which happens when editing entity fields of certain types: link, color, etc:

Fix error: Typed property Drupal\field\Entity\FieldConfig::$original must not be accessed before initialization in business_rules_field_widget_single_element_form_alter() (line 293 of modules/contrib/business_rules/business_rules.module)

I've taken the code to fix it from #3286389: Automated Drupal 10 compatibility fixes patch (MR13). In that issue, they use the same piece of code multiple times in business_rules.module but I only applied it in the line 293 because this line was the only one with property_exists checking. I've been doing some testing and in the other cases the access to original property doesn't fail.

Comment #20

rcodina

Catalan

Barcelona

commented 28 December 2023 at 12:08

Status:

Needs review

» Needs work

Just enabled testing. All style and testing errors needs to be fixed.

We need to add a composer.json like in #3286389: Automated Drupal 10 compatibility fixes but adding a dependency with dbug module too. However, this only could led to composer dependency errors until the dbug module has an official Drupal 10 release. Meanwhile, the mglaman/composer-drupal-lenient composer plugin could be used to fix this problem.

Comment #21

rcodina

Catalan

Barcelona

commented 28 December 2023 at 12:31

As expected, the latest commit didn't pass the composer validation because dbug hasn't an official D10 release yet. We can use lenient on local environment but I don't know if GitlabCI can be configured to use it. We need to specify this dependency to pass all the tests.

Comment #22

rcodina

Catalan

Barcelona

commented 29 December 2023 at 17:49

I'm just rerunning pipeline again since we already have a Drupal 10 compatible version of "dBug for Drupal".

@lexsoft Which issues are included on your first commit of MR15? Are the ones listed under Proposed resolution?

Comment #23

lexsoft commented 2 January 2024 at 13:44

@rcodina,

The MR15 includes all of this:

"drupal/business_rules": {
                "Issue #3239152: Drupal 9 - Deprecated code": "https://www.drupal.org/files/issues/2021-10-29/deprecated-entity-query-3239152-4.patch",
                "Issue #3200711: cannot add an action to a condition": "https://www.drupal.org/files/issues/2021-05-15/cannot_add_action-3200711-29.patch",
                "Issue #3123554: Execution of scheduled tasks is completely broken": "https://www.drupal.org/files/issues/2021-08-13/business_rules-schedule_task_execution_broken-3123554-11.patch",
                "Issue #3056302: Variables placed in email body not being replaced with actual value": "https://www.drupal.org/files/issues/2020-01-21/collect_variables-3056302-11.patch",
                "Issue #3087989: Duplicate condition": "https://www.drupal.org/files/issues/2020-02-06/duplicate-condition-3087989-3.patch",
                "Issue #3250592: Class RedirectResponse not found": "https://www.drupal.org/files/issues/2021-11-22/3250592-class-redirect-response-missing.patch",
                "Issue #3202890: Notice: Trying to access array offset on value of type null": "https://www.drupal.org/files/issues/2022-04-06/send-email-action-access-array-offset-on-value-of-type-null-3202890-3.patch",
                "Issue #3027292: HTML format mails showing markup tags": "https://www.drupal.org/files/issues/2022-04-06/html-format-mails-3027292-19.patch",
                "Issue #3095392: Set multiple fields values": "https://www.drupal.org/files/issues/2022-04-11/set-multiple-fields-value-action-3095392-11.patch",
                "Issue #3067571: Variable evaluation is skipped when multiple events are processed within a single request": "https://www.drupal.org/files/issues/2022-04-12/business_rules-variables_evaluation_skipped-3067571-13.patch",
                "Issue #3257814: implode() Error": "https://www.drupal.org/files/issues/2022-01-21/implode-error-3257814-5.patch",
                "Issue #3274409: Show a system message action is not rendred": "https://www.drupal.org/files/issues/2022-04-11/show-a-system-message-action-is-not-rendred-3274409-2.patch",
                "Issue #3135986: Only build matrix for flowchart when needed": "https://www.drupal.org/files/issues/2020-05-12/business_rules-lazy-matrix-3135986-2.patch",
                "Issue #3277915: Exception with flowchart on condition when used with commerce_br module": "https://www.drupal.org/files/issues/2022-05-04/exception-flowchart-matrix-position-not-empty-3277915-3.patch",
                "Issue #3283637: You have requested a non-existent service business_rules.processor": "https://www.drupal.org/files/issues/2022-06-01/requested-non-existent-service-business-rules-processor-3283637-2.patch",
                "Issue #3314230: PHP 8.1": "https://www.drupal.org/files/issues/2022-10-07/business_rules-php81_deprecation_error-3314230-2.patch",
                "Issue #3298781: PHP 8.1": "https://git.drupalcode.org/project/business_rules/-/merge_requests/9.diff",
                "Issue #3389853: Drupal 10 Compatible": "https://www.drupal.org/files/issues/2023-10-16/Drupal10_Compatible_business_rules-3389853.patch",
                "Local Patch: resolve all D10/PHP 8.1 deprecation errors": "patches/business_rules-php_8.1_deprecaation_errors.patch"
            },

Comment #24

rcodina

Catalan

Barcelona

commented 19 January 2024 at 18:31

Thanks for the list @lexsoft! I'm pushing all linked issues in a new branch 3.x one by one so I can give the deserved credit to all contributors.

Comment #25

rcodina

Catalan

Barcelona

commented 19 January 2024 at 18:32

Version:

2.x-dev

» 3.x-dev

Comment #26

rcodina

Catalan

Barcelona

commented 19 January 2024 at 19:28

@lexsoft Could you please share me the contents of patches/business_rules-php_8.1_deprecaation_errors.patch?

Comment #27

rcodina

Catalan

Barcelona

commented 19 January 2024 at 20:02

@lexsoft The contents of patches/business_rules-php_8.1_deprecaation_errors.patch won't be necessary.

Comment #28

rcodina

Catalan

Barcelona

commented 21 January 2024 at 17:51

All tests ok with latest commits.

Comment #29

rcodina

Catalan

Barcelona

commented 21 January 2024 at 17:52

Status:

Needs work

» Needs review

Comment #30

rcodina

Catalan

Barcelona

commented 21 January 2024 at 17:54

Related issues:

+#3342399: Drupal 10 compatibility

Comment #31

24 January 2024 at 17:17

rcodina committed 99c8da58 on 3.x authored by lexsoft

Issue #3261552: Business Rules 2.0.0-beta2 release plan

Comment #32

rcodina

Catalan

Barcelona

commented 24 January 2024 at 17:21

Status:

Needs review

» Fixed

Gitlab MR has not given credit to me :_(

Comment #33

lexsoft commented 25 January 2024 at 14:35

@rcodina fantastic work! Going to test this the following week.

Comment #34

26 January 2024 at 16:06

rcodina committed 5e0aced4 on 3.x

Issue #3261552 by rcodina, lexsoft: Business Rules 2.0.0-beta2 release...

Comment #35

rcodina

Catalan

Barcelona

commented 26 January 2024 at 16:07

Just added empty commit to fix credit. Just released 3.0.0-beta1.

@lexsoft Thanks for all support!

Comment #36

9 February 2024 at 16:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Business Rules 2.0.0-beta2 release plan D10 compatible

Updates

Problem/Motivation

Release-blocker issues

Good-to-fix issues

Above and beyond tasks

Remaining tasks

Original issue summary

Problem/Motivation

Proposed resolution

Issue fork business_rules-3261552

Comments

Related issues

Referenced by