Problem/Motivation
FILE: src/Form/EntityDeleteConfirmationForm.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------
46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
60 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
92 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
128 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------
FILE: src/Form/EntityDeleteForm.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------
114 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
137 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------Time: 147ms; Memory: 10MB
Steps to reproduce
Run phpcs. There's also other problems, but lets fix them in a separated issue.
Proposed resolution
Fix them all
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | entity_delete_standards.patch | 7.8 KB | j-barnes |
Comments
Comment #2
tmaiochi commentedI'll work on this.
Comment #3
j-barnes commentedComment #4
tmaiochi commentedAs @j-barnes was finished the patch I'm removing my assignment and put this to needs review.
Comment #5
baikho commentedComment #7
baikho commentedThanks for your contribution!