When no results found, the facet summary block says "1 result found". In the facet-summary-count twig template the count variable isn't taken in account.

CommentFileSizeAuthor
#3 facets_summary-summary_1_result_when_0-3252806-3.patch566 bytescgoffin

Issue fork facets-3252806

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cgoffin created an issue. See original summary.

cgoffin opened merge request !33

cgoffin’s picture

cgoffin commented
StatusFileSize
new facets_summary-summary_1_result_when_0-3252806-3.patch566 bytes

This is a problem in for example the french language. There 0 is rendered as a single value and not a plural as in english. To fix this, I also used the count variable in the single value part of the translation.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.x-dev » 2.0.x-dev
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Using this patch for a while now in a few projects.

smustgrave’s picture

smustgrave commented

This would be good to be committed for both 2.x and 3.x

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

Can we expect this to be added in 2.0.8 release soon?

  • borisson_ committed 248d804a on 3.0.x 
    Issue #3252806 by cgoffin, BramDriesen, smustgrave: Summary gives 1...

  • borisson_ committed 9a2d2bdd on 2.0.x 
    Issue #3252806 by cgoffin, BramDriesen, smustgrave: Summary gives 1...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

FYI this affects translations, meaning the existing sets would have to be added again.