Hello, when I select values ​​from the dropdown lists for the "Type specific boosting" processor (example: 21 for content, 5 for taxonomy and 1 for files), when I save, the values ​​return to 0.

Someone could help me?

CommentFileSizeAuthor
#8 3247914-8--type_specific_boost_settings_not_saved.patch5.43 KBdrunken monkey
#8 3247914-8--type_specific_boost_settings_not_saved--tests_only.patch3.31 KBdrunken monkey
#8 3247914-8--type_specific_boost_settings_not_saved--interdiff.txt2.77 KBdrunken monkey
#5 3247914-5--type_specific_boost_settings_not_saved.patch2.66 KBdrunken monkey
#5 3247914-5--type_specific_boost_settings_not_saved--tests_only.patch561 bytesdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsim01 created an issue. See original summary.

s.perilhou’s picture

s.perilhou CreditAttribution: s.perilhou commented
Category: Support request » Bug report

Hi !
Same problem here

Problem

Updated today from 1.20 to 1.21 with the new boost selection (#3201305).
Found that default boost in type-specific boosting screen configuration are all "0.00". Seems that the #default_value is not formatted. Bundles are ok.

Steps to reproduce

  • Fresh install of 1.21.
  • Add server, add index (for content and terms for example).
  • In index processors, enable type-specific boosting
  • Choose weights for default boost and save
  • Show all at "0.00" but values are saved

Proposed resolution

Format default value in TypeBoost::buildConfigurationForm

  $form['boosts'][$datasource_id] = [
    '#type' => 'details',
    '#title' => $this->t('Boost settings for %datasource', ['%datasource' => $datasource->label()]),
    '#open' => TRUE,
    'datasource_boost' => [
    '#type' => 'select',
      '#title' => $this->t('Default boost for items from this datasource'),
      '#options' => $boost_factors,
      '#description' => $this->t('A boost of 1.00 is the default. Assign a boost of 0.00 to not score the item at all.'),
      '#default_value' => Utility::formatBoostFactor($datasource_configurations[$datasource_id]['datasource_boost']),
    ],
  ];
superman369’s picture

superman369 CreditAttribution: superman369 commented

We also have the same issue in version 8.x-1.21.

gaddman’s picture

gaddman CreditAttribution: gaddman commented

s.perilhou's fix works for the case where a value is set, but still doesn't correctly display or save values where "Use datasource default" has been chosen - these show as 0 and after a save are set to 0.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Component: General code » Plugins
Status: Active » Needs review
FileSize
3247914-5--type_specific_boost_settings_not_saved--tests_only.patch561 bytes
3247914-5--type_specific_boost_settings_not_saved.patch2.66 KB

Thanks a lot for reporting this problem, and sorry it took me this long to get back to you.

I could easily reproduce the problem, the attached patch should fix it. Please test/review!

The last submitted patch, 5: 3247914-5--type_specific_boost_settings_not_saved--tests_only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3247914-5--type_specific_boost_settings_not_saved.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Version: 8.x-1.21 » 8.x-1.x-dev
Status: Needs work » Needs review
FileSize
3247914-8--type_specific_boost_settings_not_saved--interdiff.txt2.77 KB
3247914-8--type_specific_boost_settings_not_saved--tests_only.patch3.31 KB
3247914-8--type_specific_boost_settings_not_saved.patch5.43 KB

The last submitted patch, 8: 3247914-8--type_specific_boost_settings_not_saved--tests_only.patch, failed testing. View results

gaddman’s picture

gaddman CreditAttribution: gaddman commented

Tested latest patch in comment #8 and resolves issue for me.

amaria’s picture

amaria CreditAttribution: amaria commented
Status: Needs review » Reviewed & tested by the community

Works for me as well.

  • drunken monkey committed 472248f on 8.x-1.x 
    Issue #3247914 by drunken monkey: Fixed config form of the "Type-...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

Thanks for the feedback, and sorry for the long delay.
Committed. Thanks again, everyone!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.