Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
I tried to re-roll a patch recently and a lot of tests failed. The output is presented in the attached screenshots. A lot of tests fail because of an “Unexpected token ;”. Then I saw that all of the recent issues are having the same problems, with the same tests failing due to the same reason, as you can see in the related screenshots (also, the total number of tests decreased significantly from 3 months before, when everything was working fine, don’t know if it is in some way related). The issues in question where I saw the same problem are:
The one I tried to work on:
Make the entity reference handle all the entities, not just nodes
Then:
Checkboxes broken in Drupal 8.x
And also:
Undefined index field_cardinality when dependee field is a base field definition
As you can see, the tests seem to be broken since a few months ago. In the issue where I worked on, @hmendes did a patch in July that passed the 140 tests, and then today I retested his patch and it failed the same way as the others.
Since I don't have a lot of experience with tests, I couldn’t figure out what is going on, but to me it seems to be a major topic to be addressed, as it is affecting other issues too.
Steps to reproduce
Submit or see the test output of a submitted patch or MR.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3246024-3.patch | 754 bytes | hmendes |
| Issue2878592_hmendes-patch-tests-after-retest.png | 46.45 KB | marcos_lima | |
| Issue2878592_hmendes-patch-tests-before-retest.png | 32.04 KB | marcos_lima | |
| Issue3200178_patch.png | 49.81 KB | marcos_lima | |
| Issue2926437_patch.png | 34.71 KB | marcos_lima | |
Comments
Comment #2
marcos_lima CreditAttribution: marcos_lima at CI&T commentedComment #3
hmendes CreditAttribution: hmendes at CI&T commentedComment #4
marcos_lima CreditAttribution: marcos_lima at CI&T commentedThank you for the patch @hmendes. I went through the following steps:
Your patch really fixed the problem, and from the code review I did, I can’t see what was the point of the
console.logwhich was removed. I think that it didn't need to be there in the first place and that it won’t impact the tests by removing it, so to me your code looks good. The tests also passed here, so moving it to RTBC.Comment #6
colanThanks all!