Problem/Motivation

Layout Builders bootstrap Styles module loads aos.js from unpkg.com. That's a pitty, becaue GDPR forces us to load external libs just after a user has given consent to do so.

Steps to reproduce

Install Varbase as usual
look at sources panel
You'll see taht bootstrap styles fetches the library in bootstrap_styles/bootstrap_styles.libraries.yml external only.

Proposed resolution

Patch needed to be able to load the module from the libraries folder.
By now you can hack the module to load the aos.js from the modules css folder, and change the path in file mentioned above.
That is not ideal because right after updating customers using the module violating GDPR Compliant.

Remaining tasks

User interface changes

  • None

API changes

Probably some

Switched the plugin.scroll_effects.build library to use "npm-asset/aos": "~2.0"
And that will change the location of aos.js and aos.css default files to /libraries/aos/dist/aos.js and /libraries/aos/dist/aos.css

Data model changes

  • None

Comments

Joachim Namyslo created an issue. See original summary.

joachim namyslo’s picture

Title: Bootstrap styles utelices external lib only » Bootstrap styles uses external lib only
rajab natshah’s picture

Title: Bootstrap styles uses external lib only » Fix Bootstrap Styles module uses of external lib only
Project: Varbase - The Ultimate Drupal CMS Starter Kit (Bootstrap Ready) » Varbase Layout Builder
Issue summary: View changes

Thanks, Joachim for reporting.
Agrees with your proposed fix.
We can have an override-library fix in VLB and then post the patch to the Bootstrap Styles module

  • RajabNatshah committed c6fa857 on 10.0.x
    Issue #3232787: Fix Bootstrap Styles module uses of external lib only
    
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-9.0.2, +varbase_layout_builder-10.0.5
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah’s picture

rajab natshah’s picture

Title: Fix Bootstrap Styles module uses of external lib only » Fix Bootstrap Styles module uses of AOS animation external library only, for better performance and GDPR Compliant
rajab natshah’s picture

Title: Fix Bootstrap Styles module uses of AOS animation external library only, for better performance and GDPR Compliant » Fix Bootstrap Styles module uses of AOS animation external library only. For better performance and GDPR Compliant

  • RajabNatshah committed 53f81bf on 10.0.x
    Issue #3232787: Fix Bootstrap Styles module uses of AOS animation...

  • RajabNatshah committed b1017ee on 10.0.x
    Issue #3232787: Fix Bootstrap Styles module uses of AOS animation...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes