Problem/Motivation
Layout Builders bootstrap Styles module loads aos.js from unpkg.com. That's a pitty, becaue GDPR forces us to load external libs just after a user has given consent to do so.
Steps to reproduce
Install Varbase as usual
look at sources panel
You'll see taht bootstrap styles fetches the library in bootstrap_styles/bootstrap_styles.libraries.yml external only.
Proposed resolution
Patch needed to be able to load the module from the libraries folder.
By now you can hack the module to load the aos.js from the modules css folder, and change the path in file mentioned above.
That is not ideal because right after updating customers using the module violating GDPR Compliant.
Remaining tasks
- ✅ File an issue about this project
- ✅ Fix this in VLB by using
"npm-asset/aos": "~2.0" - ✅ Send patch fixes to the Bootstrap Styles module
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release varbase-9.0.2, varbase_layout_builder-10.0.5
User interface changes
- None
API changes
Probably some
Switched the plugin.scroll_effects.build library to use "npm-asset/aos": "~2.0"
And that will change the location of aos.js and aos.css default files to /libraries/aos/dist/aos.js and /libraries/aos/dist/aos.css
Data model changes
- None
Comments
Comment #2
joachim namysloComment #3
rajab natshahThanks, Joachim for reporting.
Agrees with your proposed fix.
We can have an override-library fix in VLB and then post the patch to the Bootstrap Styles module
Comment #5
rajab natshahComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshah#3226788: Provide aos.js localy to not violate GDPR
Comment #10
rajab natshahComment #11
rajab natshahComment #14
rajab natshahComment #15
rajab natshahComment #16
rajab natshahComment #17
rajab natshahComment #18
rajab natshahComment #19
rajab natshahComment #20
rajab natshahComment #21
rajab natshahComment #23
rajab natshahComment #24
rajab natshah