Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The messages about Internet Explorer 11 are a bit unclear and confusing:
- The messages say IE11 is not supported, but this might seem to imply to the end user (who doesn't know our browser support policy) that other versions of IE might be supported.
- The phrase "the benefits of CKEditor" is vague and undefined.
- Directly addressing users as "Internet Explorer 11 user:" is weird.
- We only link the supported browser list in one place whereas supported browsers are mentioned twice.
- The messages as they stand will be inaccurate in Drupal 10 since IE11 isn't itself a supported browser then. We can change the wording a little so that these messages aren't quite as out of place in D10 (although we should still have a followup to correct the text in D10).
Proposed resolution
Improve the messages.
Remaining tasks
Followup issue to simplify the messages further in D10.
User interface changes
Changed messages when configuring CKEditor and when using IE11 on a page where CKEditor is loaded.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | 3232550-19-10.0.x.patch | 6.08 KB | wim leers |
| #19 | 3232550-19.patch | 5.85 KB | wim leers |
| #18 | 3232550-18.patch | 5.84 KB | ravi.shankar |
| #2 | ckeditor5-3232550-2.patch | 3.14 KB | xjm |
Issue fork drupal-3232550
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3232550-improve-messaging-about
changes, plain diff MR !1686
Comments
Comment #2
xjmComment #3
yash.rode commentedi have reviewed the new messages and they are more accurate now.
Comment #4
yash.rode commentedComment #5
wim leersTo … remove it, I think you mean? Since D10 won't support IE11?
Comment #6
xjmNo, to simplify them and say IE11 is not supported. We should still inform the user. Thanks!
Comment #7
wim leersPer https://www.drupal.org/node/3199540, Drupal 10 is dropping IE11 support.
You're saying that despite that, we should be warning the site builder. Are we going to be sprinkling warnings like this everywhere in the UI?
Comment #8
wim leersComment #9
quietone commentedPatch no longer applies :-(
Comment #11
wim leers@lauriii clarified my confusing comments on this issue in a private chat — let me just quote him to get this issue back on the rails publicly! :D
Basically, I'm saying:
This patch here is RTBC (as soon as it's green), but we still need @xjm's confirmation that we don't need a follow-up to clarify the messages further.
Comment #14
wim leersGreat — the MR looks fine!
But we still need @xjm's confirmation per #11.
Comment #15
xjmThanks @Wim Leers. I think the D10 version of this if any is out of scope for this issue. I don't think filing a followup is a hard blocker for this, nor a stable blocker for CKE5. Retaining the messages seems harmless to me, but either way it's not blocking here. :) Up to you if you want to file it. Certainly doesn't need RM signoff either way.
I can't RTBC this since I wrote the original patch, so unassigning. Thanks!
Comment #16
wim leersFollow-up created to remove it: #3261585: Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway.
RTBC!
Comment #17
lauriiiThis needs a Drupal 10 patch.
Comment #18
ravi.shankar commentedAdded patch for Drupal 10.0.x.
Comment #19
wim leersAh, yes, once again #3253148: Remove IE from core's browserlist, remove non-essential CSS importing and recompile assets is making this painful :| I really wish we'd done that issue later, that'd have made CKE5 work far less painful.
But we'll make it work! :)
EDIT: gahh, d.o cross-post-file-upload bug biting me again…
Comment #23
lauriiiCommitted patch from #18 105b60a and pushed to 10.0.x. Also committed 9.4.x patch from #19 to 9.4.x and cherry-picked to 9.3.x because CKEditor 5 is experimental. Thanks!