Needs work
Project:
Drupal core
Version:
main
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Aug 2021 at 17:48 UTC
Updated:
21 Mar 2023 at 13:53 UTC
Jump to comment: Most recent, Most recent file
In preparation for #2158943: Add a native dialog element using HTMX to deprecate the jQuery UI dialog, we should have core equivalents of jQuery UI's dialog tests. This way, we can insure the shimmed dialog continues to pass tests.
This is similar to the tests added in #3076171: Provide a new library to replace jQuery UI autocomplete
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3230046-nr-bot.txt | 150 bytes | needs-review-queue-bot |
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
larowlanShould we be looking at something like https://github.com/testing-library/dom-testing-library here instead of nightwatch if we're releasing unit tests
This plus jest are the js equivalent of our kernel tests
Comment #5
bnjmnmAll tests are ported with the exception of
#8051 - 'Explode' dialog animation causes crash in IE 6, 7 and 8as it is targeted at browsers not supported by Drupal core.A day after the final test was written, I did a final comparison against the jQuery UI Qunit tests to confirm everything was ported, and added assertion count checks for additional assurance (and these did surface a few incomplete tests that have since been addressed).
Comment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #10
cosmicdreams commented@bnjmnm what a wonderful collection of work here. As someone who has struggled to write Nightwatch tests it would be awesome if you could break down the architecture of the test module you wrote for this. Just walking through the test module is helpful but I don't think I understand everything I need to about it. A walkthrough / blog post would be super helpful.
In regard to this issue, despite the time since the test cases were written, the work appears to be mergable if rebased. Perhaps we should discuss what the next steps here are?
Is there anything left to do?