Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Status: Active » Needs review
FileSize
1.23 KB

The calculations within core/themes/olivero/css/layout/layout-builder-threecol-section.pcss.css give an inside margin of 36px between each region. The flex-basis should calculate to calc(33% - 24px).

Because we're using decimals, in our calculations, it ends up as calc(33% - 23.976), which is obviously less than 24.

The weird thing is that it only affects IE, and it also only happens when the pxtorem postCSS plugin is enabled which is why I didn't catch that during development.

Either way, the fix is super simple: change the 0.666 to 0.667.

Patch attached.

Gauravvvv’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
148.82 KB
169.12 KB

The 33-34-33 layout is broken in IE11 is fixed now. Adding screenshots of chrome and IE11 for reference.

Marking as RTBC.

  • lauriii committed d672604 on 9.3.x
    Issue #3211888 by mherchel, Gauravmahlawat: Olivero: Layout Builder 33/...

  • lauriii committed 16ba89a on 9.2.x
    Issue #3211888 by mherchel, Gauravmahlawat: Olivero: Layout Builder 33/...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch! Committed d672604 and pushed to 9.3.x and 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.