OEmbedWidget does not display the field's help text, only its own message [#3208849]

Problem/Motivation

This field widget is designed to display "You can link to media from the following services: YouTube" if there is no help text. If there is help text, it intends to display the help text and "You can link to media from the following services: YouTube" as items in a bulleted list. But only "You can link to media from the following services: YouTube" displays, no matter if there is help text configured.

Steps to reproduce

Try setting help text on an oembed field.

Proposed resolution

Fix the tiny bug causing this.

Release notes snippet

Comment	File	Size	Author
#13	Screenshot 2021-05-20 at 17.41.12.png	37.85 KB	gauravvvv
#6	3208849.patch	878 bytes	mitthukumawat
#6	Before-patch.png	21.1 KB	mitthukumawat
#6	Before-patch.png	21.1 KB	mitthukumawat
#5	Screen Shot 2021-04-14 at 6.14.16 PM.png	22.86 KB	cilefen
#5	Screen Shot 2021-04-14 at 6.14.51 PM.png	19.31 KB	cilefen

Issue fork drupal-3208849

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3208849-oembedwidget-does-not changes, plain diff MR !561
Check out this branch for the first time

Check out existing branch, if you already have it locally
9.2.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

3208849-oembedwidget-does-not-new

changes, plain diff MR !1331

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

14 April 2021 at 22:05

cilefen created an issue. See original summary.

Comment #2

cilefen commented 14 April 2021 at 22:06

Issue summary:

View changes

Comment #3

14 April 2021 at 22:13

cilefen opened merge request !561

Comment #4

cilefen commented 14 April 2021 at 22:14

Status:

Active

» Needs review

Comment #5

cilefen commented 14 April 2021 at 22:18

Status	File	Size
new	Screen Shot 2021-04-14 at 6.14.51 PM.png	19.31 KB
new	Screen Shot 2021-04-14 at 6.14.16 PM.png	22.86 KB

Before:

before

After:

after

Comment #6

mitthukumawat commented 29 April 2021 at 05:50

Status	File	Size
new	Before-patch.png	21.1 KB
new	Before-patch.png	21.1 KB
new	3208849.patch	878 bytes

2 files were hidden/shown/deleted

Status	File	Size
hidden	Screen Shot 2021-04-14 at 6.14.51 PM.png	19.31 KB
hidden	Screen Shot 2021-04-14 at 6.14.16 PM.png	22.86 KB

I have checked with the changes and the help text is showing now.
Also I have attached a patch with the new changes.

Comment #7

mitthukumawat commented 29 April 2021 at 05:51

Status:

Needs review

» Reviewed & tested by the community

Comment #8

29 April 2021 at 05:51

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #9

larowlan

🇦🇺🏝.au GMT+10

commented 12 May 2021 at 07:01

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Bug Smash Initiative, +Needs tests

Thanks for your work here.

Because this is a bug, we require an automated test to confirm it is fixed, and that it stays fixed

Comment #10

larowlan

🇦🇺🏝.au GMT+10

commented 12 May 2021 at 07:05

1 file was hidden/shown/deleted

Status	File	Size
hidden	3208849.patch	878 bytes

Hiding the patch file because there's an MR

Comment #11

mohit_aghera commented 20 May 2021 at 09:57

Assigned:

Unassigned

» mohit_aghera

Comment #12

mohit_aghera commented 20 May 2021 at 10:38

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

Changing to Needs review as I've added tests in the PR

Comment #13

gauravvvv commented 20 May 2021 at 12:13

Status	File	Size
new	Screenshot 2021-05-20 at 17.41.12.png	37.85 KB

Patch #12, added help text and includes help text as well. can be move to RTBC.

Adding after patch screenshot for reference.

Comment #14

oktboy commented 17 September 2021 at 17:06

Thank you for the patch. This works when we add media items from Content -> Media -> Add Media -> Media Type

When the Media Library Modal opens within a content type, the text does not appear.

Drupal 8.9

Comment #15

29 September 2021 at 19:47

phenaproxima made their first commit to this issue’s fork.

Comment #16

phenaproxima

he/him

English

Massachusetts

commented 29 September 2021 at 19:49

Assigned:

mohit_aghera

» Unassigned

Test looks okay to me; I did some clean-up in there to remove some unnecessary things :) Unassigning as well. I think this is probably ready for final review/RTBC.

@oktboy:

When the Media Library Modal opens within a content type, the text does not appear.

That is expected. The media library modal does not use the field widget, so it won't show the configured help text. I think there is another open issue for that, though.

Comment #17

danflanagan8

English

St. Louis, US

commented 20 October 2021 at 17:52

Status:

Needs review

» Reviewed & tested by the community

This looks great. I reproduced the bug locally. Then I applied a patch version of the MR and saw the expected behavior.

There's no evidence of the new test ever running without the fix, but I ran the test locally without the fix and it indeed fails. So the test is good.

Comment #18

larowlan

🇦🇺🏝.au GMT+10

commented 21 October 2021 at 01:05

Removing issue credit for @mitthukumawat and @Gauravmahlawat as we already had before and after screenshots and there was an MR so no need for a patch version of it.

Comment #19

larowlan

🇦🇺🏝.au GMT+10

commented 21 October 2021 at 01:07

Status:

Reviewed & tested by the community

» Needs review

Left one minor suggestion, other than that this looks ready to go to me.

English

Pune(MH), INDIA 🇮🇳

commented 21 October 2021 at 13:53

Sorry for the noise.
Now - https://git.drupalcode.org/project/drupal/-/merge_requests/561 MR is ready to review & I closed my newly created MR - https://git.drupalcode.org/project/drupal/-/merge_requests/1331

Comment #24

larowlan

🇦🇺🏝.au GMT+10

commented 22 October 2021 at 01:59

Status:

Needs review

» Needs work

The suggestion from my review is still to be resolved

Comment #25

yogeshmpawar

He/Him/His

English

Pune(MH), INDIA 🇮🇳

commented 22 October 2021 at 06:26

Status:

Needs work

» Needs review

Updated the MR as per suggestion in #19.
Moving back to Needs Review.

Comment #26

danflanagan8

English

St. Louis, US

commented 25 October 2021 at 17:37

Status:

Needs review

» Reviewed & tested by the community

The suggestion from @larowlan has been added to the MR. Setting back to RTBC.

Comment #27

alexpott

he/they

English

🇪🇺🌍

commented 25 October 2021 at 22:16

Version:	9.3.x-dev	» 9.2.x-dev
Status:	Reviewed & tested by the community	» Fixed

Committed and pushed 2c979f05ce to 9.3.x and 1a5cc0d9ab to 9.2.x. Thanks!

Backported to 9.2.x as a low risk bug fix.

Comment #28

25 October 2021 at 22:17

alexpott committed 2c979f0 on 9.3.x

Issue #3208849 by yogeshmpawar, cilefen, phenaproxima, mohit_aghera,...

Comment #29

25 October 2021 at 22:17

alexpott committed 1a5cc0d on 9.2.x

Issue #3208849 by yogeshmpawar, cilefen, phenaproxima, mohit_aghera,...

Comment #30

8 November 2021 at 22:19

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

OEmbedWidget does not display the field's help text, only its own message

Problem/Motivation

Steps to reproduce

Proposed resolution

Release notes snippet

Issue fork drupal-3208849

Comments

Referenced by