Problem/Motivation

The iframe module provides an iframe field that allows settings the various attributes of an iframe.
This would provide a robust way to set additional attributes (width, height, etc.).

Proposed resolution

media_iframe could depend on the iframe module and use an iframe field in InlineFrame (instead of an url field).

CommentFileSizeAuthor
#6 3204574-6.patch6.03 KBjibran
#6 interdiff-45339d.txt292 bytesjibran
#2 3204574-2.patch6.02 KBjibran

Issue fork media_iframe-3204574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Use the iframe module? » Use the iframe module
Category: Feature request » Task
Status: Active » Needs review
StatusFileSize
new 3204574-2.patch6.02 KB

Here we go.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Use the iframe module » Use the iframe field from module for media iframe source plugin

Status: Needs review » Needs work

The last submitted patch, 2: 3204574-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Use the iframe field from module for media iframe source plugin » Use the iframe field from iframe module for media iframe source plugin

#3204981: Update config schema will fix the test fails.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-45339d.txt292 bytes
new 3204574-6.patch6.03 KB

This should be applicable via composer.

  • jibran committed cdad3d1 on 1.0.x 
    Issue #3204574 by jibran: Use the iframe field from iframe module for...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Fixed

Committed and pushed to 1.0.x.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 1.0.0-alpha1 » 1.0.x-dev

  • jibran committed e26127d on 1.0.x 
    Issue #3204574 by jibran: Fixed typo in the module description.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

richardbporter made their first commit to this issue’s fork.