Problem/Motivation

The UI still has various bits about Drupal 9 compatibility.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Finds the proper problems on Drupal 9:

API changes

Data model changes

CommentFileSizeAuthor
#7 Screenshot 2021-03-03 at 15.02.10.png127.95 KBgábor hojtsy
#7 Screenshot_2021-03-03 Upgrade status Drupal 9.png298.46 KBgábor hojtsy
#7 interdiff.txt8.21 KBgábor hojtsy
#7 3201336-7.patch38.04 KBgábor hojtsy
#5 3201336.patch32.39 KBgábor hojtsy

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy credited andypost.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Crediting @andypost for starting work on this at #3201156: Make Upgrade Status logic make sense on Drupal 9.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Assigned: Unassigned » gábor hojtsy
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new 3201336.patch32.39 KB

Posting an in-progress patch. The tests need more updating as the total number of errors change based on major Drupal core version, among other things. I'm going to continue on this in the afternoon.

Status: Needs review » Needs work

The last submitted patch, 5: 3201336.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3201336-7.patch38.04 KB
new interdiff.txt8.21 KB
new Screenshot_2021-03-03 Upgrade status Drupal 9.png298.46 KB
new Screenshot 2021-03-03 at 15.02.10.png127.95 KB

This makes sense now as far as I see. I did run into #3182653: PHPUnit 9.4.3 Fatal error: Trait 'Prophecy\PhpUnit\ProphecyTrait' not found while running locally.

Added screenshots to issue summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Awesome! Will review tonight

PS thinking about to split each core version subset of "checklist" into separate helper classes

  • Gábor Hojtsy committed c1c1f89 on 8.x-3.x 
    Issue #3201336 by Gábor Hojtsy, andypost: Update Upgrade Status UI for...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

This was released already.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.