PHPUnit 9.4.3 Fatal error: Trait 'Prophecy\PhpUnit\ProphecyTrait' not found

I got it after upgrading to Composer 2
adding phpspec/prophecy-phpunit fixed the issue

The problem is that Drupal 9 is compatible with both PHPUnit 8 and PHPUnit 9, but we only need phpspec/prophecy-phpunit on PHPUnit 9 and it won't install if you have PHPUnit 8 so we can't add it as a dependency.

The command composer drupal-phpunit-upgrade exists already to upgrade PHPUnit and add the dependency for you.

This is also documented in the change record at https://www.drupal.org/node/3176567

I'm not sure there is a way of making this more foolproof while we are compatible with both versions?

What about adding it as suggestion to the composer.json?

{
    "suggest": {
        "phpspec/prophecy-phpunit": "Needed if you are using PHPUnit 9.x, but don't install together with PHPUnit 8.x. See https://www.drupal.org/node/3176567 for details."
    }
}

At least this gives the user a hint when running composer install or composer update that he might have to add phpspec/prophecy-phpunit as dependency.

I just ran into this. I did composer drupal-phpunit-upgrade as provided in #4 and that worked just fine. I added that solution to the IS, keeping the original.

We are running into this as well on DrupalSpoons. The proposal to run composer drupal-phpunit-upgrade does not work for any site built on core-composer-scaffold since that script is defined in drupal/drupal but not in drupal/core. We can't easily hard code the contents of the script because it varies by Drupal version.

Also running into this when testing 9.1.x-dev on docker. This tracks with @moshe-weitzman thoughts regarding drupal/core. I install as follows:

composer create-project drupal/recommended-project:9.1.x-dev drupal9 --stability dev --no-interaction \
  && cd drupal9 \
  && composer require --dev drupal/core-dev:9.1.x-dev \
  && composer require drush/drush \
  && composer up

When I try to run composer drupal-phpunit-upgrade as provided in #4 the script is not available. However using composer require phpspec/prophecy-phpunit does fix it :-)

Fixed broken CR link

I've helped two people on Slack today with this error message alone.

I wonder if we can add some detection code that detects this state and tells the user what to do?

#10 and #11 sound like a good idea to me.

Ran into this exact problem today while setting up a new dev site for Upgrade Status locally. This pointed me in the right direction.

Slight query with the wording of the patch in #11:

PHPUnit 9 requires Prophecy PhpUnit.

Isn't it that Drupal requires Prophecy PhpUnit when testing with PHPUnit 9?

PHPUnit 9 doesn't require Prophecy PhpUnit by itself, or it would be in PHPUnit's requirements.

Patch attached with shameless bikeshedding from #14

Adding interdiff

Good point.

Wouldn't that make sense to do something like `shell_exec('composer require --dev phpspec/prophecy-phpunit')`?

Better to tell the user what to do rather than try and fix it, as we might not be able to run Composer.

We have similar instructions in run-tests.sh if PHPUnit is not installed at all or the wrong version.

Wouldn't that make sense to do something like `shell_exec('composer require --dev phpspec/prophecy-phpunit')`?

I think if we actually started automatically running composer commands when people run unit tests, that would be very confusing.

We also don't know if composer is on the path so this might not even work.

Makes sense 👍

+++ b/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit9/TestCompatibilityTrait.php
@@ -4,6 +4,11 @@
+  print "Drupal requires Prophecy PhpUnit when using PHPUnit 9. Please use 'composer require --dev phpspec/prophecy-phpunit' to ensure that it is present.\n";

This looks like a fine approach to me. I think we should limit this to we do in drupal-phpunit-upgrade - ie. composer require --dev phpspec/prophecy-phpunit:^2

We also should add an @todo to remove when the minimum PHPUnit is 9 because then we can add this as a real dependency.

Further, let's say "when using PHPUnit 9 or greater" - or something like that.

Addressed #22.

Have reviewed the patch in #23, it includes the suggested changes from #22.
Todo comment added - there is no current issue for removing PHPUnit 8 so we don't need to reference one here.
Hence setting back to RTBC.

Committed and pushed cbccba94b6 to 9.2.x and 94d0c1f1f2 to 9.1.x. Thanks!

So I tried searching the issue queue for this and it didn't show. So I'll comment what I got back in my phpstan-drupal testing:

Reflection error: Prophecy\PhpUnit\ProphecyTrait not found.
Class Prophecy\PhpUnit\ProphecyTrait not found.
Failed asserting that actual size 2 matches expected size 0.

hi, i use
PHPUnit 9.5.5
Drupal core 9.2.0

when i try use
vendor/bin/phpunit -c phpunit.xml
or
SIMPLETEST_BASE_URL=http://localhost/c17062021/ ./vendor/bin/phpunit -c core/ --testsuite functional --filter SkeletonTest
i always get
PHP Fatal error: Trait 'Symfony\Bridge\PhpUnit\Legacy\PolyfillAssertTrait' not found in /var/www/html/c17062021/sites/simpletest/Assert.php on line 91

any idea?, thanks.

That could be https://www.drupal.org/node/3217694

Adding composer require --dev symfony/phpunit-bridge worked for me.

@arshadkhan35,

I have tried it but still getting the same error.

Please check my reply here - https://www.drupal.org/project/drupal/issues/3346242#comment-15387854

Were you able to run any contributed module tests?

Thanks,