Closed (fixed)
Project:
CKEditor Wordcount
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2021 at 16:52 UTC
Updated:
13 May 2021 at 09:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jcnventuraComment #3
kevinquillen commentedLets be sure to update the README too to match.
Comment #4
jcnventuraAs per #3
Comment #5
kevinquillen commentedLGTM, how does this work exactly? How can I test the process?
Comment #6
jcnventuraYou need to
composer require wikimedia/composer-merge-pluginand add the following to the site's composer.json:
Where [docroot] is your site's root (web/docroot).
Comment #7
jcnventuraComment #8
kevinquillen commentedAll seems good to me if both ways work for folks.
Comment #10
jcnventuraComment #11
hchonovThat was a BC break and should've required a new major version. Sites that used to retrieve the library aren't retrieving it anymore. I am re-openning the ticket for eventual revert.
Comment #12
jcnventuraSorry @hchonov, but the previous composer.json dependency never worked correctly, so it's not a real BC-break. See #3172165: Composer setup does not install the plugin in the libraries folder
It only worked if you used the
mnsami/composer-custom-directory-installerplugin and had prepared the composer.json like in the previous instructions. And yes, I do realize a few select sites might be in that situation. The solution for those is to fix those site's composer.json. Reverting is not an option.Comment #14
jcnventuraI've created a 1.4 release that re-introduces the dependency on
w8tcha/ckeditor-wordcount-pluginComment #15
jcnventuraOK. So version 1.4 is even worse as it triggers a problem in one of the composer plugins (not sure if mnsami/composer-custom-directory-installer, or oomphinc/composer-installers-extender or wikimedia/composer-merge-plugin), that results in the library not being installed.
At this point, I don't think that it is possible to keep the composer.libraries.json in the 1.x branch. I'll create a 1.5 release that removes it, and
then a 2.0 release that uses it and will be almost exactly the same as version 1.3.
Sorry about this mess everyone.
Comment #17
jcnventura