| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3198954-10.patch | 6.74 KB | sourabhjain |
Issue fork cas_server-3198954
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
albertski commentedComment #5
rob230 commentedAll you did was add version requirement. You need to also remove all the deprecated code otherwise it is not Drupal 9 compatible.
Comment #6
texas-bronius commentedFyi, install https://www.drupal.org/project/upgrade_status and get a nice report. See below for example via drush :)
Comment #8
aroseman commentedComment #9
texas-bronius commented@aroseman, did you intend to post a patch with your issue status change? As far as this queue goes, per #5 and #6, work still remains beyond just marking the module as D9 compatible.
Comment #10
sourabhjainTried to fix the issue which are mentioned in the #6. Please review.
Comment #11
aroseman commented@texas-bronius,
Relatively new to this process. I addressed deprecated code issues and pushed those changes to the issue fork (commit). I have not created a patch. I will look into that process assuming @sourabhjain's patch doesn't address those issues.
Comment #13
jollysolutionsTests need updateing.
Comment #14
aroseman commentedGood call @jollysolutions. I'll address the tests later today.
Comment #15
rwohlebComment #16
rwohleb... ignoring the confusing automated suggestions from upgrade_status, it just needs to be updated to "Drupal\Core\Entity\Query\QueryFactoryInterface" instead. Still the drupal_set_message() bits of course.Oof, I'm not used to the new issue fork stuff yet. The existing MR #1 fork handles what I thought was still missing.
Comment #18
rwohlebI've added MR3 that fixes references to "drupal_set_message()", "REQUEST_TIME", and "entity.query" service.
Comment #20
bucefal91 commentedhello guys!
There's also another deprecation that we have been missing until now. In web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:
On the outside, it produces the following error during
drush cim:Just defining that annotation property with meaningful data hopefully should be enough. I did confirm
drush cim/drush cexcontinue to work properly on a CAS Server config entity.Comment #22
rob230 commentedThank you, I've tested merge request 3. No issues with cim/cex.
Comment #24
j_ten_man commentedComment #25
umitMany thanks to everyone for the support.