When adding a basic block and embed media on layout builder, on edit media javascript error appears
"Uncaught RangeError: Maximum call stack size exceeded".

It is calling a function which in turn calls another function and so forth until you hit the call stack limit.

CommentFileSizeAuthor
#2 3194571.patch805 bytesabdelrahman amer

Comments

Abdelrahman Amer created an issue. See original summary.

abdelrahman amer’s picture

StatusFileSize
new805 bytes
rajab natshah’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3194571.patch, failed testing. View results

rajab natshah’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Thank you for reporting and patching
It will bring the following yarn eslint issues

rajab@vardot-dev:/var/www/html/products/varbase_layout_builder$ yarn eslint
yarn run v1.22.10
$ node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .

/var/www/html/products/varbase_layout_builder/js/vlb-configure-section.admin.js
  44:22  warning  'context' is defined but never used             no-unused-vars
  50:49  error    Use the rest parameters instead of 'arguments'  prefer-rest-params

✖ 2 problems (1 error, 1 warning)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It was changed in
#3173443: Add yarn script commands for Drupal coding standard and Drupal Practice for Varbase Layout Builder
after it was in
#3122537: Fix CKEditor text-fields issue of not clickable texts due to interaction with core/drupal.dialog

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-8.8.9, +varbase-9.0.0-rc2, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Status: Fixed » Closed (fixed)