Closed (fixed)
Project:
Varbase Layout Builder
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Mar 2020 at 09:20 UTC
Updated:
29 Apr 2020 at 10:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
yasmeensalah commentedAccording to the related issue, Comment #17 will solve the issue.
Comment #3
yasmeensalah commentedComment #4
rajab natshahThank you Yasmeen for reporting and patching
Valid issue
Let us check first on All Deprecated unused jQuery UI asset libraries
as jQuery UI is being phased out from Drupal core
They are replaced by other libraries
like Popper.js added to Drupal core to replace jQuery UI Position
#3051352: [Plan] Remove unused jQuery UI components and replace with a suite of contrib packages for the continuous upgrade path
https://www.drupal.org/list-changes/drupal/published?keywords_descriptio...
Let us check if
core/jquery.ui.dialogwill stay in coreComment #5
rajab natshahComment #6
mohammed j. razemCan you replace the patch to use Popper.js instead of jQuery UI? Or is Popper.js not ready yet to be used?
Comment #7
rajab natshahNow Popper.js is loaded and used in all the site - Back-End and Front-End
Not sure if it will do the same function in dialogs or modals
Lauri from the Drupal Acceleration Team and Acquia helped us
In #3115895: Provide support for Popper.js ^2.0.0 core/popperjs library and Drupal 9
Updating to the latest Vartheme BS4 will help
https://www.drupal.org/project/vartheme_bs4/releases/8.x-6.8
Using
core/popperjsfrom Drupal core inPlease follow with #3115895: Provide support for Popper.js ^2.0.0 core/popperjs library and Drupal 9
If you needed to update your old generated sub theme
I do think
core/jquery.ui.dialogmay stay in core codeif you search for it in #3051352: [Plan] Remove unused jQuery UI components and replace with a suite of contrib packages for the continuous upgrade path
Comment #8
rajab natshahPopperjs is a replacement for something else
Popper.js added to Drupal core to replace jQuery UI Position
https://www.drupal.org/node/3086643
core/jquery.ui.dialoghas no replacement yet!core.libraries.yml
Better to use
core/drupal.dialogso it will work even if they did the switch to other ui libraryComment #9
rajab natshahComment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #15
rajab natshahComment #16
rajab natshahComment #17
rajab natshah