Problem/Motivation

#3178071: Fix config schema did not actually fix config schema and lacks a test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new2.07 KB

Here's a test to prove things are still broken

Status: Needs review » Needs work

The last submitted patch, 2: 3178809-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexpott’s picture

Status: Needs work » Needs review
StatusFileSize
new2.43 KB
new31.22 KB

And here's the schema properly fixed and tested for both the main theme and the subtheme.

Also can automated testing be enabled for the 5.x branch?

The last submitted patch, 4: 3178809-3-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexpott’s picture

StatusFileSize
new1.04 KB
new31.17 KB

Tidying up the schema file a touch...

alexpott’s picture

The patch doesn't apply because 8.x-4.x does not have #3178071: Fix config schema applied... that's why we need testing enabled on the 5.x branch.

alexpott’s picture

StatusFileSize
new14.02 KB

Rolling again on top of HEAD as there's been another commit on #3178071: Fix config schema but it's not complete.

  • hatuhay committed c666bad on 5.x authored by alexpott
    Issue #3178809 by alexpott: Properly fix and test config schema
    
hatuhay’s picture

Status: Needs review » Fixed

Thanks for taking the time to split the patch.
I took some private hours to mantain the theme and it is hard to deep into every bug detail to apply and test in short times.

alexpott’s picture

@hatuhay no problem - it's definitely the correct thing to split the patch out. Any chance you can turn on automated testing on 5.x - thanks!

alexpott’s picture

@hatuhay also thanks for taking the time to maintain this theme :)

rajab natshah’s picture

Thank you Alex , Thank you Alberto.

We had
#3138991: Fix schema mapping for Bootstrap Barrio
Then
#3165663: Revert #3138991
But now
#3178071: Fix config schema
#3178809: Properly fix and test config schema

Thank you again Alberto for all the private hours you put into the Barrio theme.

All big projects have bugs or issues which sometimes hard to track or slip at the time
When I look at commits at Drupal core I do see many things like this. reverts and revert for the revert.

Happy to have Alberto maintaining the Bootstrap Barrio theme.
Using your theme as the base theme in all our projects.

rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dravenk made their first commit to this issue’s fork.

dravenk’s picture

@alexpott
Create an MR that only deletes the merged patch, please review. https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/2

alexpott’s picture

StatusFileSize
new14.02 KB

If anyone needs this on 8.x-4.x here is a patch.