Problem/Motivation
#3178071: Fix config schema did not actually fix config schema and lacks a test.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | 3178809-8.x-4.x-21.patch | 14.02 KB | alexpott |
| #8 | 3178809-8.patch | 14.02 KB | alexpott |
| #6 | 3178809-5.patch | 31.17 KB | alexpott |
| #6 | 3-5-interdiff.txt | 1.04 KB | alexpott |
| #4 | 3178809-3.patch | 31.22 KB | alexpott |
Issue fork bootstrap_barrio-3178809
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
alexpottHere's a test to prove things are still broken
Comment #4
alexpottAnd here's the schema properly fixed and tested for both the main theme and the subtheme.
Also can automated testing be enabled for the 5.x branch?
Comment #6
alexpottTidying up the schema file a touch...
Comment #7
alexpottThe patch doesn't apply because 8.x-4.x does not have #3178071: Fix config schema applied... that's why we need testing enabled on the 5.x branch.
Comment #8
alexpottRolling again on top of HEAD as there's been another commit on #3178071: Fix config schema but it's not complete.
Comment #10
hatuhay commentedThanks for taking the time to split the patch.
I took some private hours to mantain the theme and it is hard to deep into every bug detail to apply and test in short times.
Comment #11
alexpott@hatuhay no problem - it's definitely the correct thing to split the patch out. Any chance you can turn on automated testing on 5.x - thanks!
Comment #12
alexpott@hatuhay also thanks for taking the time to maintain this theme :)
Comment #13
rajab natshahThank you Alex , Thank you Alberto.
We had
#3138991: Fix schema mapping for Bootstrap Barrio
Then
#3165663: Revert #3138991
But now
#3178071: Fix config schema
#3178809: Properly fix and test config schema
Thank you again Alberto for all the private hours you put into the Barrio theme.
All big projects have bugs or issues which sometimes hard to track or slip at the time
When I look at commits at Drupal core I do see many things like this. reverts and revert for the revert.
Happy to have Alberto maintaining the Bootstrap Barrio theme.
Using your theme as the base theme in all our projects.
Comment #14
rajab natshahI have noticed that the 3178809-8.patch file is committed
https://git.drupalcode.org/project/bootstrap_barrio/-/tree/5.x
Comment #20
dravenk@alexpott
Create an MR that only deletes the merged patch, please review. https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/2
Comment #21
alexpottIf anyone needs this on 8.x-4.x here is a patch.