Problem/Motivation

There have been a couple of dependency updates since #3176504: Upgrade dependencies prior to 9.1.0 - let's update before the alpha.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

+-------------------------------+--------+--------+
| Production Changes            | From   | To     |
+-------------------------------+--------+--------+
| symfony/http-client-contracts | v2.2.0 | v2.3.1 |
+-------------------------------+--------+--------+

+-------------------+---------+---------+
| Dev Changes       | From    | To      |
+-------------------+---------+---------+
| composer/composer | 1.10.14 | 1.10.15 |
+-------------------+---------+---------+
CommentFileSizeAuthor
#7 3178046-9.1.x-7.patch4.56 KBalexpott
#2 3178046-2.patch4.38 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Priority: Normal » Critical
Status: Active » Needs review
FileSize
3178046-2.patch4.38 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

I've made this critical due to...

+++ b/composer.lock
@@ -7324,5 +7325,5 @@
-    "plugin-api-version": "2.0.0"
+    "plugin-api-version": "1.1.0"

Composer 2 seeping into core composer config...

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Priority: Critical » Major

So far #3 has not had any negative effects reported (we tested it with 9.07 and 8.9.7 on purpose). AFAIK it will get changed depending on the Composer version used by the person who most recently did a Composer update of core (most often the release managers).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

EDIT: duplicate of previous comment

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Note that we need a separate 9.1.x patch; post-8.8.0 different branches will always have mismatched lockfiles.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
3178046-9.1.x-7.patch4.56 KB

Here's a patch for 9.1.x. Amusingly the conflict is on the diff in #3 - also the composer bin thing is flipping again.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

#7 for 9.1.x looks good to me.
#2 for 9.2.x, I think we could stick with "plugin-api-version": "2.0.0" to inline with 9.1.x switching to composer 2, otherwise, it's RTBC to me.

Thanks!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

In addition to #8, should/could we upgrade PHPUnit to 9 in 9.2.x?

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Reviewed & tested by the community

As the title indicated, it's for 9.1.x. so setting to RTBC.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Reviewed & tested by the community » Needs review

I got confused that in composer.lock, it's "plugin-api-version": "1.1.0". See https://git.drupalcode.org/project/drupal/-/blob/9.1.x/composer.lock#L7327. Changing back to NR

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

@jungle the plugin-api-version doesn't matter. It only records what version of composer was used to do the build. It'll flip-flop. We shouldn't be committing composer.lock at all.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

See https://github.com/composer/composer/search?q=plugin-api-version - it's not actually used by composer and is not even part of the lock file hash :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Re #9 no - that's optional. We need to stay on PHPUnit 8 whilst we still support it so we run tests with it. As said before we shouldn't check in composer.lock but we should do min-max testing instead.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

+1 rtbc

  • catch committed 066f155 on 9.2.x 
    Issue #3178046 by alexpott, jungle, xjm: Update dependencies for 9.1.x

  • catch committed 0b9b8e6 on 9.1.x 
    Issue #3178046 by alexpott, jungle, xjm: Update dependencies for 9.1.x
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed the patches to 9.2.x and 9.1.x respectively, thanks!

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

See https://github.com/composer/composer/search?q=plugin-api-version - it's not actually used by composer and is not even part of the lock file hash :)

@alexpott, thanks for the clarification.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.1.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.