Deprecate overloading arguments to WebAssert methods to prevent conversions of legacy Simpletest test to carry over cruft

I Will work on this.

Here I have added a patch which might fix failed tests of patch #2.

I have added string as a comment as suggested in comment #7.

It still needs work for remaining things of comment #7.

This is great, thanks @mondrake for filing this.

1. I would suggest adding a dynamic one to $dynamic_skipped_deprecations in \Drupal\Tests\Listeners\DeprecationListenerTrait::isDeprecationSkipped()

2. +++ b/core/tests/Drupal/Tests/WebAssert.php
   @@ -642,4 +694,354 @@ public function pageContainsNoDuplicateId() {
   +  public function elementsCount($selectorType, $selector, $count, ElementInterface $container = null) {
   ...
   +  public function elementExists($selectorType, $selector, ElementInterface $container = null) {
   ...
   +  public function elementNotExists($selectorType, $selector, ElementInterface $container = null) {
   ...
   +  public function fieldExists($field, TraversableElement $container = null) {
   ...
   +  public function fieldNotExists($field, TraversableElement $container = null) {
   ...
   +  public function fieldValueEquals($field, $value, TraversableElement $container = null) {
   ...
   +  public function fieldValueNotEquals($field, $value, TraversableElement $container = null) {
   ...
   +  public function checkboxChecked($field, TraversableElement $container = null) {
   ...
   +  public function checkboxNotChecked($field, TraversableElement $container = null) {
   

   Should be $container = NULL

3. Applied issue template

Thanks @mondrake!

1. #13.1 - actually we should not silence, but remove cruft

   You are RIGHT!

2. Should we add @legacy tests testing deprecated messages?

3. +++ b/core/modules/path/tests/src/Functional/PathAliasTest.php
   @@ -414,7 +414,7 @@ public function testDuplicateNodeAlias() {
   +    $this->assertSession()->pageTextContains(t('1 error has been found: URL alias'));
   

   Looks like t() call could be removed.

4. +++ b/core/tests/Drupal/Tests/WebAssert.php
   @@ -70,6 +71,9 @@ protected function cleanUrl($url) {
   +      @trigger_error('Calling ' . __METHOD__ . ' with more than two arguments is deprecated in drupal:9.1.0 and will throw an exception in drupal:10.0.0. See https://www.drupal.org/node/TODO', E_USER_DEPRECATED);
   
   ...
   
   @@ -92,6 +96,9 @@ public function buttonExists($button, TraversableElement $container = NULL) {
   +      @trigger_error('Calling ' . __METHOD__ . ' with more than two arguments is deprecated in drupal:9.1.0 and will throw an exception in drupal:10.0.0. See https://www.drupal.org/node/TODO', E_USER_DEPRECATED);
   
   

   CR needed/CR URL to be updated, setting back to NW for this at least.

Changin status to needs review as patch #17 passed the tests.

#3133355: Introduce PHPUnit-compliant WebAssert::responseHeaderExists() method, and its negative landed, so we can add to WebAssertTest, but also not sure about adding 52 new functional tests just to cover these deprecations.

Nice work on the unit tests for this! I reviewed all the changes and don't see any issues here.

+++ b/core/modules/path/tests/src/Functional/PathAliasTest.php
@@ -414,7 +414,7 @@ public function testDuplicateNodeAlias() {
-    $this->assertSession()->pageTextContains(t('1 error has been found: URL alias'), 'Form error found with expected text.');
+    $this->assertSession()->pageTextContains('1 error has been found: URL alias');

Great that we are fixing these, this was surely an incorrect use of t() anyway.

This is some top-shelf work folks - I love that we both fix it and prevent it happening further

Committed 050b91b and pushed to 9.1.x. Thanks!

Published the change record.

Would you please list in the CR which WebAssert methods are affected by this, so a search of the change records for a specific deprecated method will reveal this change and so we have guidance on what we need to change to be D9.1-compatible? Yeah, I guess I could figure it out by myself on a case-by-case basis when this change affects one of my projects, but it would be much easier if there were a list so I could just grep to see if this is even an issue for my projects and so I can fix all cases at the same time.