WebAssert methods do not have a $message argument like AssertLegacyTrait methods

on it

sorry assign my mistake so un-assign this issue

Doing some grep-work on assertSession calls.

it looks like assertNotMatches() is a frequent culprit.

responseNotContains() occasionally

responseContains() at least once

pageTextContains() and pageTextNotContains() a bunch

These are the only ones I can see on a cursory skim.

To be sure we get all, we could let the CI run a test patch that replaces WebAssert with a subclass that overrides all methods, adds an optional argument to them all, and triggers a warning if that argument isn't empty.

I guess it's worth a try.

If this works, this should trigger a deprecation notice for any call to a WebAssert method with a superfluous extra argument.

syntax error

It looks like it partially worked; but there are also some errors because I forgot about JSWebAssert.

(and WebDriverWebAssert)

Looks like those failures are all the calls in core that will need to be adjusted.

Checking WebAssert again, it looks like there are several methods that *do* support a $message argument, these being:

\Drupal\Tests\WebAssert::linkByHrefExists
\Drupal\Tests\WebAssert::linkByHrefNotExists
\Drupal\Tests\WebAssert::linkExists
\Drupal\Tests\WebAssert::linkExistsExact
\Drupal\Tests\WebAssert::linkNotExists
\Drupal\Tests\WebAssert::linkNotExistsExact

plus these four of the inherited methods:

\Behat\Mink\WebAssert::assert
\Behat\Mink\WebAssert::assertElement
\Behat\Mink\WebAssert::assertElementText
\Behat\Mink\WebAssert::assertResponseText

Huh, sorry I didn't notice this issue, and I opened another one in #3160405: Deprecate overloading arguments to WebAssert methods to prevent conversions of legacy Simpletest test to carry over cruft.

I'm skeptical about

+++ b/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php
@@ -421,7 +422,10 @@ function t(r, lx, ly) {
-  public function assertNoEscaped($raw) {
+  public function assertNoEscaped($raw, $_message = NULL) {
+    if ($_message) {
+      @trigger_error('WebAssert method called with superfluous argument.', E_USER_DEPRECATED);
+    }

because this would actually add useless arguments... and we could use func_num_args() here instead, that would check the number of arguments passed in, even if overloaded against the signature ones.

That's what the other issue is doing - if we agree, I'd make this one closed (duplicate).

I'm closing this as duplicate of #3160405: Deprecate overloading arguments to WebAssert methods to prevent conversions of legacy Simpletest test to carry over cruft. @cburschka I'll ask in the other issue to credit you for your work in this.