Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.88 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 9 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 9.

Currently Drupal-Rector, version 0.5.5, cannot fix all Drupal 9 compatibility problems.

This patch does not update the info.yml file for Drupal 9 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 9 compatibility fixes as they become available in Drupal-Rector.

Debug info

Bot run #1477

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.5
  3. rector/rector-prefixed: dev-master

Status: Needs review » Needs work

The last submitted patch, 2: bootstrap_rijkshuisstijl.1.x-dev.rector.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

martijn de wit’s picture

Issue summary: View changes
Related issues: +#3079112: Deprecated Code Report
avinashm’s picture

Status: Needs work » Needs review
StatusFileSize
new3.19 KB

Patch for core version compatibility with drupal 9.

Status: Needs review » Needs work

The last submitted patch, 5: 3146300-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bryandenijs’s picture

One more deprecated function call eliminated.

\Drupal\Core\Session\AccountInterface::getUsername() was deprecated.
You have to use Use \Drupal\Core\Session\AccountInterface::getAccountName() or \Drupal\user\UserInterface::getDisplayName() instead.
In this case I chose \Drupal\user\UserInterface::getDisplayName()

bryandenijs’s picture

Status: Needs work » Needs review

The last submitted patch, 7: 3146300-fix-deprecated-function-call-7.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 7: 3146300-interdiff-5-7.diff, failed testing. View results

bryandenijs’s picture

StatusFileSize
new604 bytes
new3.28 KB

Whoops. Interdiff file has wrong extension and caused the automated tests to fail.
Here same patch and interdiff, but with .txt extension.

bryandenijs’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 11: 3146300-fix-deprecated-function-call-7.patch, failed testing. View results

bryandenijs’s picture

Status: Needs work » Needs review
StatusFileSize
new3.71 KB
new984 bytes

Whoops I'm sorry. Apparently the fix didn't make it into the patch file. Must be the hot weather.

Here's a retry!

P.s. automated tests seem to fail because there aren't any :)

Status: Needs review » Needs work

The last submitted patch, 14: 3146300-fix-deprecated-function-call-14.patch, failed testing. View results

batigolix’s picture

Status: Needs work » Reviewed & tested by the community

I tested this patch and I did not encounter any problems. But the changes in this patch conflict with the ones in #3079112: Deprecated Code Report, so I propose to fix that one first and reroll the patch in this issue.

batigolix’s picture

Status: Reviewed & tested by the community » Postponed
batigolix’s picture

Status: Postponed » Needs work
batigolix’s picture

Status: Needs work » Needs review
StatusFileSize
new319 bytes

All the changes (except the one in info.yml) in the #14 patch were already included in #3079112: Deprecated Code Report which has been committed.

So all that is left is the change in bootstrap_rijkshuisstijl.info.yml

@BryanDeNijs : it would be nice if you could review and approve this.

Status: Needs review » Needs work

The last submitted patch, 19: 3146300-fix-deprecated-function-call-19.patch, failed testing. View results

bryandenijs’s picture

Status: Needs work » Reviewed & tested by the community

Ah oops, sorry didn't see the #3079112: Deprecated Code Report issue.
Then the latest patch is enough!
Tested and works like a charm!

batigolix’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.