[D8] Views RSS Feed Authentication

Thanks for contribution :)
Here is a brief summary of the issues found from the Automated Review.
https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git

FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | Unused variable $current_path.
23 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
29 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------

FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
36 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
37 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
68 | WARNING | Messages are user facing text and must run through t()
| | for translation
--------------------------------------------------------------------------

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/vrssfa.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
36 | ERROR | [x] Short array syntax must be used to define arrays
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
42 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
| | found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
12 | ERROR | [x] Missing class doc comment
15 | ERROR | [x] There must be no blank lines after the function comment
65 | ERROR | [x] Object operator not indented correctly; expected 6
| | spaces but found 9
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
69 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
| | found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

Hi ramu_bharu,

Thanks for your contribution!

still have some issues, please fix.

Review of the 8.1.x branch (commit 59b1314):

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• Remove all .DS_Store files from your repository.
• The vrssfa.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
  --------------------------------------------------------------------------
   19 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
   21 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
   21 | WARNING | Unused variable $current_path.
   23 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
   29 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
  --------------------------------------------------------------------------
  
  
  FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
  --------------------------------------------------------------------------
   37 | WARNING | t() calls should be avoided in classes, use dependency
      |         | injection and $this->t() instead
   38 | WARNING | t() calls should be avoided in classes, use dependency
      |         | injection and $this->t() instead
   69 | WARNING | \Drupal calls should be avoided in classes, use
      |         | dependency injection instead
  --------------------------------------------------------------------------
  
  Time: 251ms; Memory: 4Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/vrssfa.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
 1 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 36 | ERROR | [x] Short array syntax must be used to define arrays
 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 42 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
    |       |     found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement
 13 | ERROR   | [x] Missing class doc comment
 16 | ERROR   | [x] There must be no blank lines after the function
    |         |     comment
 66 | ERROR   | [x] Object operator not indented correctly; expected 6
    |         |     spaces but found 9
 70 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 70 | ERROR   | [x] Closing brace indented incorrectly; expected 2
    |         |     spaces, found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 436ms; Memory: 4Mb

../vendor/bin/drupal-check modules/contrib/vrssfa/ -ad

3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git-8.1...

Pareview is not resolved. Please resolve all issues.

@ramu_bharu Still pending

https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git-8.1.x

FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
28 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------

Time: 251ms; Memory: 4Mb

Remember to change status when the code has been fixed.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.