Compatible with D9. So, Add core_version_requirement: ^8 || ^9 to info.yml file.

CommentFileSizeAuthor
#2 3127898-2.patch393 bytesshaktik

Comments

shaktik created an issue. See original summary.

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
StatusFileSize
new 3127898-2.patch393 bytes
shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
Status: Active » Needs review
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs review » Reviewed & tested by the community

Change looks good to me. Ready for RTBC status.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Issue tags: +Drupal 9 compatibility
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Needs work

------ ----------------------------------------------------------------------
Line views_bootstrap.theme.inc
------ ----------------------------------------------------------------------
35 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
203 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Reviewed & tested by the community

Oops, #6 was from 3x branch. Switched to 4x and that's been fixed. RTBC seems like the right status at this point.

chris matthews’s picture

chris matthews commented

@aburrows, since D9 is just a few weeks away would it be possible to commit this to dev and tag a D9 compatible release?

chris matthews’s picture

chris matthews commented
Status: Reviewed & tested by the community » Fixed

Thanks for committing, changing status to fixed. Would it be possible to tag a 8.x-4.3 release with this commit?

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
Status: Fixed » Reviewed & tested by the community

Hi @Chris Matthews,

Yes you right, you need to create a new tag from 8.x-4.x to 8.x-4.3 because commit not added on this 8.x-4.2 - branch/tag.
https://git.drupalcode.org/project/views_bootstrap/-/tree/8.x-4.2

Thanks,
Shakti.

chris matthews’s picture

chris matthews commented
Status: Reviewed & tested by the community » Fixed

@shaktik, this was committed on 8.x-4.x so the status should be fixed.
@aburrows, any chance you could go ahead and tag 8.x-4.3 and fill in the 'D9 porting info' field on the project edit page?

aburrows’s picture

aburrows commented
Status: Fixed » Closed (fixed)

Bootstrap 4 is released for Drupal 9.