I love this sub-theme, THANK YOU!

Just a couple of missing variables in the variables.scss file that is causing the themes to error out when compiling. Obviously the Variables import needs to be able to override Bootstrap so it needs to remain at the top. I have added just a couple of basic variables from bootstrap so that it wouldn't error out when compiling.

Added $gray-900, $orange (for when someone uncomments the other colors ).
Removed $gray-lighter for $gray-100.
Removed the background color in the style.scss override so it doesn't confuse people out of the gate.

In regards to the SCSS conflict structure.
- I do agree that maybe the structure should be looked at, but I get why its there. Its of an example of how you can override your stuff and allows you to setup your own structure.

CommentFileSizeAuthor
#9 3126964-9.patch636 bytesnishamukta
#9 diff-3126964-9.txt1.77 KBnishamukta
#7 addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch797 bytesnishamukta
#7 diffrence-addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch1.94 KBnishamukta
#5 addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch796 bytesnishamukta
#2 31269644-prevent-compile.patch1.29 KBkclarkson

Comments

kclarkson created an issue. See original summary.

kclarkson’s picture

kclarkson commented
StatusFileSize
new 31269644-prevent-compile.patch1.29 KB
introfini’s picture

introfini commented

#2 fixes all the compilation issues. Thanks.

vistree’s picture

vistree commented

Good morning @kclarkson,
thanx for your fix. I am wondering - why aren't those variables taken from /themes/custom/custom_theme/node_modules/bootstrap/scss/_variables.scss
Is this because of the presence of a custom varialbes.scss? I thought that only variables that exist in both files will be overwritten by the one included later ...

nishamukta’s picture

nishamukta commented
Status: Active » Needs review
StatusFileSize
new addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch796 bytes

i have also added patch for this which was stopping for compiling @vistree these variable aren't taken from /themes/custom/custom_theme/node_modules/bootstrap/scss/_variables.scss since this file is included below variables in import.css of current theme

kclarkson’s picture

kclarkson commented

@nshall11,

please review my patch before posting yours I am not seeing any difference.

nishamukta’s picture

nishamukta commented
StatusFileSize
new diffrence-addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch1.94 KB
new addition-of-variables-to-prevent-errors-during-compiling-3126964-5.patch797 bytes

@kclarkson i am adding the difference in these files between yours and mine. i specifically added patch for only those error which we was getting during compiling.

kaurg’s picture

kaurg commented

@nisha11 Can you please add only 1 correct patch.

nishamukta’s picture

nishamukta commented
StatusFileSize
new diff-3126964-9.txt1.77 KB
new 3126964-9.patch636 bytes

added patch and diff file which is difference of other patch. please review

kaurg’s picture

kaurg commented
Status: Needs review » Reviewed & tested by the community

Patch is working correctly

  • hatuhay committed 3918667 on 8.x-1.x authored by nisha11 
    Issue #3126964 by nisha11, kclarkson: Addition of Variables to Prevent...
hatuhay’s picture

hatuhay commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.