Greetings,
First off all, thank you for this SASS great sub-theme for Barrio. I've noticed an issue and more globally a structure problem, if i am not wrong.
In variables.scss you have commented the bootstrap native variable for the the body attribute "$body-bg" for us to be able to use it.
The problem is that in style.scss you also use the "$body-bg" and it overwrite the one in variables.scss if we use it. thus if we use "$body-bg" in variables.scss it has no effect. Also the variable "$gray-dark" in variables.scss is not defined.
More globally i think it s not a structured approach to process style.css ans put style directly in it, it s like we have to put all our style in that sheet, most people will have a more structured approach and use separate scss for layout, region or module for exemple.
Thus I think nativaly you should process import.scss. And put a more structured approach with the scss with differents folders corresponding on the Drupal object instead of putting all in the components folder.
PS: English is not my mother tongue, thus my apologies for any writing errors.
Comments
Comment #2
OCTOGONE.dev commentedComment #3
hatuhay commentedComment #4
kclarkson commented@Octogon.dev,
I understand why @hatuhay has built the theme this way. It allows the user to create their own structure and styles.scss file is just an example. But I did remove the body style in my patch in the styles.scss file because a new user could be confused if they changed the variable and stuff didn't change.
Addition of Variables to Prevent Errors During Compiling