The path of the message.messages route is defined as : admin/content/message
This is also the menu entry: content > message (in the toolbar)

The path of the message.multiple_delete_confirm route is defined as : admin/content/message/delete

Unfortunately, the view view.message.page_1 and all other paths have admin/content/messages as a base path (with a "s" at the end of messages).

This leads to some missing functionalities... I think we should choose with or without "s" for everywhere...

CommentFileSizeAuthor
#15 message2.png42.81 KBbalagan
#13 message.png39.97 KBbalagan

Issue fork message-3124695

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuneBL created an issue. See original summary.

DuneBL’s picture

DuneBL
Primary language French
CreditAttribution: DuneBL commented
Title: messages or message which is the rout? » messages or message which is the route?
cosolom’s picture

cosolom CreditAttribution: cosolom commented

I think that need to merge this routes in one. Now admin/content/message is uninformative and admin/content/messages should be used as main route.

liquidcms’s picture

liquidcms CreditAttribution: liquidcms commented

would this also fix why there is no route to the message entity?

even drupal console created entities get a canonical link to the entity at: admin/structure/message/[mid]

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 opened merge request !24

bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Status: Active » Needs review
bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Status: Needs review » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support to this project makes other volunteer contributions more sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triaging issues and adding more context to existing issues.
  • Writing documentation or patches for this project.
  • Writing blog posts or speaking about it at conferences.

  • bluegeek9 committed e7c41262 on 8.x-1.x 
    Issue #3124695 by bluegeek9: messages or message which is the route?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

balagan’s picture

balagan CreditAttribution: balagan at Gizra commented

Now we have a view with path: 'admin/content/message' and this path is also specified in the message.routing.yml file

message.messages:
  path: '/admin/content/message'
  defaults:
    _title: 'Messages'
    _entity_list: 'message'
  requirements:
    _permission: 'overview messages'
bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Status: Closed (fixed) » Active

@balagan,

The view is optional. If the view is not installed, the entity list is displayed. The view overrides the entity list when it is installed.

I am open to removing the route from message.routing.yml.

balagan’s picture

balagan CreditAttribution: balagan at Gizra commented
FileSize
message.png39.97 KB

The problem is, currently the Messages tab under /admin/content doesn't display. As the view is optional, maybe should revert this change and keep the different paths?

bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented

The missing message tab is a real issue. I think the EntityList should be removed from message.routing.yml and update message.links.task.yml. Or, maybe the view can be updated to have a tab.

I am opposed to having two paths. It isn't very clear. The view is better than the entity list, both in appearance and because site builders can modify a view.

If you want to retain the entity list and allow the view to override it, and retain the message tab, we can try updating the view to have a tab. Another option is to create a controller for the route. If the view is present display the view, otherwise the entity list.

balagan’s picture

balagan CreditAttribution: balagan at Gizra commented
FileSize
message2.png42.81 KB

Removing the message.messages route from the message.routing.yml file and its link from the message.links.yml file solves the problem.
The Message tab displays, linking to the view, and the link from the toolbar dropdown is removed.

bluegeek9 opened merge request !35

  • bluegeek9 committed 036ef522 on 8.x-1.x 
    Issue #3124695 by bluegeek9: messages or message which is the route?
bluegeek9’s picture

bluegeek9 CreditAttribution: bluegeek9 as a volunteer commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.