Compatibility with Drupal 9 [#3123150]

Changed check function to static function and added to re-test.

Comment	File	Size	Author
#24	3123150-23-24.diff	1.69 KB	danharper
#24	3123150-24.patch	4.79 KB	danharper
#23	3123150-21-23.diff	685 bytes	danharper
#23	3123150-23.patch	6.4 KB	danharper
#21	3123150-21.patch	6.38 KB	danharper
#20	3123150-20.patch	4.51 KB	danharper
#17	3123150-17.patch	3.17 KB	mrpauldriver
#16	3123150-16.patch	3.17 KB	mrpauldriver
#15	3123150-15.patch	3.17 KB	mrpauldriver
#13	3123150-13.patch	3.17 KB	mrpauldriver
#11	3123150-10.diff	940 bytes	danharper
#11	3123150-10.patch	2.06 KB	danharper
#4	3123150-4.patch	2.02 KB	suresh prabhu parkala
#2	3123150-2.patch	346 bytes	neslee canil pinto

Comments

Comment #1

28 March 2020 at 16:56

Neslee Canil Pinto created an issue. See original summary.

Comment #2

neslee canil pinto

he/him

English

commented 28 March 2020 at 16:57

Status:

Active

» Needs review

Status	File	Size
new	3123150-2.patch	346 bytes

Comment #3

mandclu commented 4 June 2020 at 23:21

Status:

Needs review

» Needs work

According to the warnings I'm seeing, all the submodules need the same fix.

Status	File	Size
new	3123150-4.patch	2.02 KB

Comment #5

rajesh_jha commented 6 July 2020 at 10:45

Greetings!
Requesting you to kindly release a new version of this module with Drupal 9 Compatibility as almost the Core Commerce module is already working with Drupal 9.Thanks and regards.

Comment #6

mrpauldriver commented 3 August 2020 at 15:05

Patch at #4 would not apply

Comment #7

mrpauldriver commented 3 August 2020 at 17:01

I checked this with Upgrade Status module and quite a lot a work seems to be required. Much more that just changing the core_version_requirement.

CUSTOM PROJECTS
--------------------------------------------------------------------------------
Commerce Stock API
Scanned on Mon, 03/08/2020 - 16:25.

47 warnings found.

web/modules/contrib/commerce_stock/modules/enforcement/tests/src/Functional/Enfo
rcementBrowserTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 15   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/enforcement/tests/src/Functional/Enfo
rcementBrowserTestBase.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 10   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/enforcement/tests/src/Functional/OutO
fStockTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 15   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/enforcement/tests/src/Kernel/Enforcem
entKernelTestBase.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 10   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/field/tests/src/Functional/StockLevel
FieldTestBase.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 13   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/field/tests/src/Functional/StockLevel
FormatterTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 12   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/field/tests/src/Functional/StockLevel
WidgetsTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 16   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/field/tests/src/Kernel/StockLevelTest
.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 22   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/src/Form/PrepareUninsta
llForm.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Ignore │ 90   │ Call to deprecated method isSubclassOf() of class            │
│        │      │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in        │
│        │      │ drupal:8.3.0 and is removed from drupal:10.0.0. Use          │
│        │      │ Drupal\Core\Entity\EntityTypeInterface::entityClassImplement │
│        │      │ s() instead.                                                 │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/Entity
/StockLocationTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 15   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/LocalS
tockServiceTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 19   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/LocalS
tockUpdaterTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 20   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/OrderE
ventTransactionsKernelTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 23   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/OrderE
ventsTransactionsTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 28   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/src/Kernel/StockL
ocationStorageTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 13   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/src/Form/StockConfigForm.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Ignore │ 63   │ Call to deprecated method isSubclassOf() of class            │
│        │      │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in        │
│        │      │ drupal:8.3.0 and is removed from drupal:10.0.0. Use          │
│        │      │ Drupal\Core\Entity\EntityTypeInterface::entityClassImplement │
│        │      │ s() instead.                                                 │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/src/StockAvailabilityChecker.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 16   │ Class Drupal\commerce_stock\StockAvailabilityChecker        │
│ manually │      │ implements deprecated interface                             │
│          │      │ Drupal\commerce\AvailabilityCheckerInterface. Deprecated in │
│          │      │ commerce:8.x-2.18 and is removed from commerce:3.x. Use     │
│          │      │ Drupal\commerce_order\AvailabilityCheckerInterface instead. │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/Functional/ProductAdminTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 13   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/Functional/StockBrowserTestBase.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 17   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/Functional/StockServiceTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 12   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/FunctionalJavascript/StockWebDriver
TestBase.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 17   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/Kernel/CommerceStockKernelTestBase.
php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 10   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/tests/src/Kernel/StockServiceManagerTest.php:
┌──────────┬──────┬─────────────────────────────────────────────┐
│  STATUS  │ LINE │                   MESSAGE                   │
├──────────┼──────┼─────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
│ Check    │ 11   │ Class PHPUnit\Framework\TestCase not found. │
│ manually │      │                                             │
└──────────┴──────┴─────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/commerce_stock.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/ui/commerce_stock_ui.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/commerce_stock_local.in
fo.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/modules/commerce_
stock_local_test/commerce_stock_local_test.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/field/commerce_stock_field.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/enforcement/commerce_stock_enforcemen
t.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Comment #8

mandclu commented 4 August 2020 at 13:37

@MrPaulDriver for the errors about PHPUnit\Framework\TestCase being not found, is it possible you were running this without having drupal/core-dev installed?

Comment #9

guy_schneerson commented 7 August 2020 at 10:52

Thanks, Paul, I think this confirms things are probably ok. If we ignore the tests (as @mandclu was saying is probably an issue with running the tests), we only have two places using the deprecated function isSubclassOf() and that will only get removed in Drupal 10.
@MrPaulDriver can you have a look if the test issue is a setup one and if you can fix that re-run the report and update your comment with the results?

Comment #10

mrpauldriver commented 18 September 2020 at 14:00

Just circling back round to this, sorry for the delay. Yes, I'll get this tested on against Drupal 8 again.

In the meantime I just found the module is not installable via composer against a Drupal 9 site, prior to patching.

An interim dev release would be a big help so that anyone starting a new commerce site doesn't have to start with 8, patch commerce_stock and then upgrade to 9. Even if it didn't work, at least it could be installed.

Comment #11

danharper commented 18 September 2020 at 12:55

Status	File	Size
new	3123150-10.patch	2.06 KB
new	3123150-10.diff	940 bytes

patches above don't apply on latest dev, new patch attached with diff from #4

Comment #12

mrpauldriver commented 19 September 2020 at 08:49

After patching with #11, two items needing attention remain, together with two others which can be ignored for now. I expect those to ignore relate to Drupal 10 as hinted by Guy at #9.

CUSTOM PROJECTS
--------------------------------------------------------------------------------
Commerce Stock API
Scanned on Fri, 09/18/2020 - 14:55.

2 warnings found.

web/modules/contrib/commerce_stock/modules/local_storage/src/Form/PrepareUninsta
llForm.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Ignore │ 90   │ Call to deprecated method isSubclassOf() of class            │
│        │      │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in        │
│        │      │ drupal:8.3.0 and is removed from drupal:10.0.0. Use          │
│        │      │ Drupal\Core\Entity\EntityTypeInterface::entityClassImplement │
│        │      │ s() instead.                                                 │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/src/Form/StockConfigForm.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Ignore │ 63   │ Call to deprecated method isSubclassOf() of class            │
│        │      │ Drupal\Core\Entity\EntityTypeInterface. Deprecated in        │
│        │      │ drupal:8.3.0 and is removed from drupal:10.0.0. Use          │
│        │      │ Drupal\Core\Entity\EntityTypeInterface::entityClassImplement │
│        │      │ s() instead.                                                 │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/src/StockAvailabilityChecker.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 16   │ Class Drupal\commerce_stock\StockAvailabilityChecker        │
│ manually │      │ implements deprecated interface                             │
│          │      │ Drupal\commerce\AvailabilityCheckerInterface. Deprecated in │
│          │      │ commerce:8.x-2.18 and is removed from commerce:3.x. Use     │
│          │      │ Drupal\commerce_order\AvailabilityCheckerInterface instead. │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_stock/modules/local_storage/tests/modules/commerce_
stock_local_test/commerce_stock_local_test.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Comment #13

mrpauldriver commented 18 September 2020 at 15:04

Status	File	Size
new	3123150-13.patch	3.17 KB

Patch for 2 current items outstanding.

Comment #14

18 September 2020 at 15:11

Status:

Needs review

» Needs work

The last submitted patch, 13: 3123150-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #15

mrpauldriver commented 18 September 2020 at 15:36

Status	File	Size
new	3123150-15.patch	3.17 KB

Try again. Misplaced ; I think.

Comment #16

mrpauldriver commented 18 September 2020 at 15:43

Status	File	Size
new	3123150-16.patch	3.17 KB

Comment #17

mrpauldriver commented 18 September 2020 at 16:01

Status	File	Size
new	3123150-17.patch	3.17 KB

Comment #18

dave kopecek

he/him

commented 18 September 2020 at 21:33

Using composer & composer-patches I can apply #17 against a D8 site, however when applied against a D9 site it fails.

This is apparently a chicken-and-egg problem. Composer won't download commerce_stock because the existing dev version requires D8. The patch is what allows D9 compatibility & it hasn't been applied yet. Is there a magic composer command that will fix this? Do we just need to do a non-composer manual install and patch until this issue is resolved?

I know this isn't a problem with #17, but this is my first encounter with this dilemma and google is failing me.

Comment #19

mrpauldriver commented 19 September 2020 at 08:54

Yes this is a chicken and egg problem because the dev release can not be installed on Drupal 9 with composer. It therefore has to be patched for Drupal 8.9 first.

The latest patch does apply (with D8) and passes checks with Upgrade Status module, however it is currently failing tests here.

That your manual installation for D9 fails, suggests more work is needed.

Comment #20

danharper commented 19 September 2020 at 12:45

Status	File	Size
new	3123150-20.patch	4.51 KB

To test you need to add this to the composer file, this enables composer to download it.
"drupal/core": "9.0.6 as 8.9.6",

I have attached another patch, this does apply using the above in composer and I have tested it with a clean install using commerce 2.x-dev (make sure you didn't already have commerce stock enabled otherwise it breaks)

Comment #21

danharper commented 19 September 2020 at 15:50

Issue summary:

View changes

Status	File	Size
new	3123150-21.patch	6.38 KB

Comment #22

dave kopecek

he/him

commented 21 September 2020 at 18:21

Thanks @danharper for "drupal/core": "9.0.6 as 8.9.6". That did the trick.

- Patch 20 applies against a 9.0.6 site
- Patch 21 gives error:

Fatal error: Cannot make non static method Drupal\commerce_order\AvailabilityCheckerInterface::check() static in class Drupal\commerce_stock\StockAvailabilityChecker in /var/www/web/modules/contrib/commerce_stock/src/StockAvailabilityChecker.php on line 17

Comment #23

danharper commented 9 October 2020 at 14:57

Status	File	Size
new	3123150-23.patch	6.4 KB
new	3123150-21-23.diff	685 bytes

New patch attached with diff for #21 to this one.

Comment #24

danharper commented 9 October 2020 at 16:02

Status	File	Size
new	3123150-24.patch	4.79 KB
new	3123150-23-24.diff	1.69 KB

New patch to remove some changes below that are in several files.

< -use Symfony\Component\EventDispatcher\Event;
< +use Symfony\Contracts\EventDispatcher\Event;

Comment #25

mrpauldriver commented 9 October 2020 at 16:16

Patch installs cleanly and passes tests with Upgrade Status module. Now needs verifying on a Drupal 9 installation.

Comment #26

danharper commented 9 October 2020 at 16:22

Status:

Needs work

» Needs review

Changing to needs review, I have tested local storage in a very basic way.

Comment #27

mrpauldriver commented 10 October 2020 at 15:53

Status:

Needs review

» Reviewed & tested by the community

No problem installing under Drupal 9.0.6 and Commerce 8.x-2.21

The module functionality seems okay, however I only tried a very basic configuration. I suggest if problems are discovered, these could be raised as separate issues.

Marking as RTBC.

Comment #28

agoradesign commented 29 October 2020 at 16:11

would be nice, if that could get committed soon please incl new release :)

Comment #29

promes

Dutch

commented 5 November 2020 at 16:42

I would like to start using this module in D9. When will there be a new release?
Thanks for the hard work.

Issue #3123150 by danharper, MrPaulDriver, Neslee Canil Pinto:...

Comment #33

guy_schneerson commented 12 November 2020 at 11:14

Status:

Reviewed & tested by the community

» Fixed

Great work. I will push a new version over the weekend.

Comment #34

guy_schneerson commented 17 November 2020 at 14:51

The new release
https://www.drupal.org/project/commerce_stock/releases/8.x-1.0-alpha5

Comment #35

1 December 2020 at 14:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.