Add core_version_requirement: ^8 || ^9 to time_formatter.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#2 3117911-2.patch393 bytespavnish

Comments

pavnish created an issue. See original summary.

pavnish’s picture

pavnish commented
Assigned: pavnish » Unassigned
Status: Active » Needs review
StatusFileSize
new 3117911-2.patch393 bytes

Patch Added

boobaa’s picture

boobaa
he/him
commented
Status: Needs review » Postponed (maintainer needs more info)

Let's get back to this once D9 is reportedly stable, ie. there's an RC at least to test against.

meet_bhanvadia’s picture

meet_bhanvadia commented
Status: Postponed (maintainer needs more info) » Needs review

As drupal 9 is released. Marking as need review.

meet_bhanvadia’s picture

meet_bhanvadia commented
Status: Needs review » Reviewed & tested by the community

Hi All,

Patch #2 works for me!!

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented

Manually tested with composer patching & works fine on 1.x-dev 👍

Gathering patches for dependencies. This might take a minute.
- Installing drupal/time_formatter (dev-1.x 6d9e8e5): Cloning 6d9e8e580b from cache
- Applying patches for drupal/time_formatter
https://www.drupal.org/files/issues/2020-03-05/3117911-2.patch (#3117911 - Add core version requirement support for drupal 9)

nitvirus’s picture

nitvirus commented

Any Update when this patch would be rolled in module for drupal 9 compatibility.

steinmb’s picture

steinmb commented
Status: Reviewed & tested by the community » Needs work

I think the core: 8.x statement must go since it should also work on 9.

sarvjeetsingh’s picture

sarvjeetsingh commented

hey, @steinmb, are you sure about that? Because I think we should keep core: 8.x so that this module is also compatible with drupal 8.7.7 and earlier versions of drupal.

sheshsharma’s picture

sheshsharma commented
Status: Needs work » Reviewed & tested by the community

Hi,

core: 8.x i think it should work.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented

Please refer https://www.drupal.org/docs/creating-custom-modules/let-drupal-know-abou...

when a module supports all version of D8 & D9 it should have

core: 8.x
core_version_requirement: ^8 || ^9

Maintainers any update on when this would be committed ?

  • gobinathm committed 11d889c on 2.0.x authored by pavnish 
    Issue #3117911 by pavnish, meet_bhanvadia, gobinathm: Add core version...
gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Status: Reviewed & tested by the community » Fixed
nitvirus’s picture

nitvirus commented

thanks for the commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

grumpydev74’s picture

grumpydev74
Primary language French
Location Geneva, CH 🇨🇭
commented

Hi,

is a new release with the requirements for drupal 9 version is on its way ?

It will be great to have it before drupal 8 EOF (2nf of Novembrer 2021) : https://www.acquia.com/blog/nows-time-prepare-drupal-8-end-life#:~:text=....

Created a new task for that here : https://www.drupal.org/project/time_formatter/issues/3238421

thank you in advance