I'm using Danland for some time now, first on Drupal 7 and later on version 8.
It would be great if the version 8 of Danland could be adapted for version 9 of Drupal.
I think, the only adaptation that should be done would be in the info.yml file according to this link:Here it is
Drupal 9 will be release in june and because this is not so much work…
The new version could run on both Drupal 8 and 9.
Thank you
Eric

CommentFileSizeAuthor
#2 compatibility-with-drupal-9-3108237-2.patch686 bytesDeepthi kumari
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

EricVL created an issue. See original summary.

Deepthi kumari’s picture

Deepthi kumari CreditAttribution: Deepthi kumari as a volunteer and at TA Digital commented
Status: Active » Needs review
FileSize
compatibility-with-drupal-9-3108237-2.patch686 bytes

Attached patch. Please review.

EricVL’s picture

EricVL CreditAttribution: EricVL commented

Thank you very much Deepthi kumari for delivering your patch to make the theme compatible with Drupal 9 but I have a problem to applying the patch.
The problem is that the content of the file "danland.info.yml" in the downloaded zip or jar file is different of the one that is in the git configuration management.

In git from line 34 on it is:
page_bottom: Page bottom
screenshot: screenshot.png
libraries:
- danland/global

In the downloaded file from line 34 on it is:

page_bottom: Page bottom
screenshot: screenshot.png
libraries:
- danland/global
# Information added by Drupal.org packaging script on 2016-01-29
version: '8.x-1.0'
core: '8.x'
project: 'danland'
datestamp: 1454052240

This has probably to do with the package mechanism of Drupal.

Because the patch works on those last lines the patch mechanism fails to adapt the file.

Could you check again please so that the patch works. I'm trying to setup composer to automatically adapt the file.
Thanks in advance.
Greetings
Eric

EricVL’s picture

EricVL CreditAttribution: EricVL commented
Status: Needs review » Needs work
EricVL’s picture

EricVL CreditAttribution: EricVL commented
Status: Needs work » Active

  • kunalkapoor committed fd60b3b on 8.x-1.x 
    Issue #3108237 by Deepthi kumari: Compatibility with Drupal 9
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Active » Fixed
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Fixed » Closed (fixed)
tjtj’s picture

tjtj CreditAttribution: tjtj commented

This patch failed for me:

htdocs/kacb/public_html/web/themes/contrib/danland # patch -p1 < compatibility-with-drupal-9-3108237-2.patch
patching file danland.info.yml
Hunk #2 FAILED at 35.
1 out of 2 hunks FAILED -- saving rejects to file danland.info.yml.rej

and

# cat danland.info.yml.rej
--- danland.info.yml
+++ danland.info.yml
@@ -35,4 +36,4 @@ regions:
   page_bottom: Page bottom
 screenshot: screenshot.png
 libraries:
-  - danland/global+  - danland/global

I removed the stuff at the end of the danland.info.yml file, and installed it in a new drupal 9 installation.
But I get the following message:

 Error: Call to undefined function file_scan_directory() in danland_preprocess_page() (line 64 of
 /srv/www/htdocs/kacb9/web/themes/contrib/danland/danland.theme) #0 /srv/www/htdocs/kacb9/web