php drupal-check.phar modules/contrib/media_entity_soundcloud/
 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------- 
  Line   media_entity_soundcloud.install                        
 ------ ------------------------------------------------------- 
  14     Call to deprecated function file_prepare_directory().  
  25     Call to deprecated function file_unmanaged_copy().     
 ------ ------------------------------------------------------- 

 ------ --------------------------------------------------------- 
  Line   src/Plugin/media/Source/Soundcloud.php                   
 ------ --------------------------------------------------------- 
  113    Call to deprecated function file_prepare_directory().    
  116    Call to deprecated function file_unmanaged_save_data().  
 ------ --------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/SoundcloudEmbedFormatterTest.php                                                                                                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  15     Usage of deprecated trait Drupal\Tests\media\Functional\MediaFunctionalTestCreateMediaTypeTrait in class Drupal\Tests\media_entity_soundcloud\Functional\SoundcloudEmbedFormatterTest.  
  59     Call to deprecated function entity_get_form_display().                                                                                                                                  
  65     Call to deprecated function entity_get_display().                                                                                                                                       
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 7 errors
CommentFileSizeAuthor
#21 3086691-21-interdiff.txt1019 bytesjkswoods
#21 3086691-21.patch7.37 KBjkswoods
#20 3086691-20-interdiff.txt327 bytesjcisio
#20 3086691-20.diff6.37 KBjcisio
#16 3086691-16.patch6.36 KBlarowlan
#16 3086691-16-interdiff.txt1.58 KBlarowlan
#14 drupal9-compatibility-3086691-14.patch6.43 KBsonvir249
#11 3086691-11.patch5.96 KBaleksip
#9 3086691-9.patch5.46 KBaleksip
#7 3086691-7.patch5.12 KBaleksip
#4 3086691-4.patch4.18 KBsahana _n
#2 deprecated-3086691-2.patch5.69 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3086691-2.patch5.69 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-3086691-2.patch, failed testing. View results

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new 3086691-4.patch4.18 KB

Please review the patch.

millerrs’s picture

millerrs commented

#4 works for me.

Status: Needs review » Needs work

The last submitted patch, 4: 3086691-4.patch, failed testing. View results

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented
Title: Deprecated Code Report » Drupal 9 compatibility
Status: Needs work » Needs review
StatusFileSize
new 3086691-7.patch5.12 KB

- Changed deprecated trait in SoundcloudEmbedFormatterTest
- Added core_version_requirement
- Renamed issue title

Status: Needs review » Needs work

The last submitted patch, 7: 3086691-7.patch, failed testing. View results

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new 3086691-9.patch5.46 KB

Fixed changed createmediatype() call in SoundcloudEmbedFormatterTest

Status: Needs review » Needs work

The last submitted patch, 9: 3086691-9.patch, failed testing. View results

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new 3086691-11.patch5.96 KB

Looks like Drupal now redirects to /admin/content/media after saving a media item, but the test expects a redirect to /media/[id]. So this part of the test needs to be rewritten. I have commented it with a @todo for now just to see if everything else passes.

himerus’s picture

himerus commented

This patch seems to be failing on latest code, which makes no sense if it passed previously as nothing has changed in the codebase for 2 years.

jcisio’s picture

jcisio commented
Status: Needs review » Needs work

Now that tests have been fixed, could you remove unrelated changes?

sonvir249’s picture

sonvir249 commented
Status: Needs work » Needs review
StatusFileSize
new drupal9-compatibility-3086691-14.patch6.43 KB

Rerolled the patch for Drupal 9 support.

Status: Needs review » Needs work

The last submitted patch, 14: drupal9-compatibility-3086691-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3086691-16-interdiff.txt1.58 KB
new 3086691-16.patch6.36 KB

Interdiff is from #11

stijndmd’s picture

stijndmd commented

Can I help test wether or not this patched version works with composer?
And how do I do this?

jkswoods’s picture

jkswoods commented

Tested the patch on a local installation, everything (creating/updating/deleting, oEmbed response, media library etc.) working as normal

Do we need to look at the D9.1 composer require failure before marking this as RTBC?

@stijndmd You can look in to using https://github.com/cweagans/composer-patches if you want to install patches with composer

jcisio’s picture

jcisio commented
Status: Needs review » Needs work

It seems like that the dependency "drupal:media (>= 8.4)" implies to Composer "drupal/core:^8.4", which eventually is a core bug. I think we can simply remove the version in this dependency.

jcisio’s picture

jcisio commented
Status: Needs work » Needs review
StatusFileSize
new 3086691-20.diff6.37 KB
new 3086691-20-interdiff.txt327 bytes
jkswoods’s picture

jkswoods commented
StatusFileSize
new 3086691-21.patch7.37 KB
new 3086691-21-interdiff.txt1019 bytes

@jcisio Nice, I did some digging and apparently to test dependency changes we need a composer.json https://www.drupal.org/docs/creating-custom-modules/let-drupal-know-abou...

jkswoods’s picture

jkswoods commented
Related issues: +#3157542: Error when having a composer.json dependency on a non-ready D9 module

Different error this time which appears to be documented elsewhere

devad’s picture

devad commented
Status: Needs review » Reviewed & tested by the community

Thnx. Patch #21 works for me with latest D9.1.x-dev with no errors in logs. Marking RTBC.

It would be nice to have working d9 version soon.

stijndmd’s picture

stijndmd commented

@jskwoods I'm well aware on how to apply patches with composer.

Just wondering how I can make this work on d9 because even if I place the patch in composer, this module still doesn't want to install because drupal 8 is required.

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented

@stijndmd One way is to fork the module, apply the patch and then point Composer to use your fork until a D9-compatible version of the module is released.

jcisio’s picture

jcisio commented
Status: Reviewed & tested by the community » Fixed

I think the patch is good enough and we spend energy elsewhere for the "real" issues. New release created. Thank you for all the work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.