aria-pressed attribute isn't updated correctly.

Ported patch for tour.

It would be awesome if we could have test coverage to prove this is broken and fixed! 🙂

Edit: Just noticed it was mentioned as a remaining task in the issue summary! ✌️

Here is a test that proves the bug.

Here's a patch that proves the bug is fixed.

Sorry for the wrong comment number in the names of the patches, my mistake :(

Updated patches

The prior patches only covered the tour button, this patch expands to cover the other toolbar buttons (as far as I can tell), and adds a test for toggling the "manage" tray, which is isolated in the test-only patch.

Updated because FunctionalJavascript tests now require specifying $defaultTheme.

Just some nits

1. +++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
   @@ -42,10 +42,15 @@ public function testToolbarToggling() {
   +    $this->assertEqual($manage_link->getAttribute('aria-pressed'), 'true');
   ...
   +    $this->assertEqual($manage_link->getAttribute('aria-pressed'), 'false');
   ...
   +    $this->assertEqual($manage_link->getAttribute('aria-pressed'), 'true');
   

   these should use assertEquals (and then the arguments need to be swapped around)

2. +++ b/core/modules/tour/tests/src/FunctionalJavascript/TourJavascriptTest.php
   @@ -0,0 +1,58 @@
   +    self::assertSame('false', $tour_toolbar_button->getAttribute('aria-pressed'), 'The "Tour" button in the toolbar is not yet pressed.');
   +    self::assertFalse($tour_toolbar_button->hasClass('is-active'), 'The "Tour" button in the toolbar is not yet marked as active.');
   ...
   +    self::assertSame('true', $tour_toolbar_button->getAttribute('aria-pressed'), 'The "Tour" button in the toolbar is pressed.');
   +    self::assertTrue($tour_toolbar_button->hasClass('is-active'), 'The "Tour" button in the toolbar is marked as active.');
   

   In core we don't use self:: here but $this->

Patch contains fixes according to #14 and #15 comments

Can someone add a patch for 9.1?

Thanks @andrewmacpherson. I have tried with "add test/ retest" link mentioned in #16 and executed for Drupal 9.1 but it has failed

Tried to fix the failed test cases. Thank You

Applied patch #26 successfully

"aria-pressed" attribute is updated correctly after applying the patch

Before patch

aria-pressed attribute is false for the selected "Admin" button before applying the patch

After patch

aria-pressed attribute is true for the selected "Admin" button after applying the patch

Rerun the last patch #26 & now phpunit seems to be happy with it. Resetting to needs review.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Patch for Drupal version 10.1.x

Applied patch #37 successfully

Verified and tested patch #37 on 10.1.x-dev. Patch applied cleanly.

Test Result:
"aria-pressed" attribute of toolbar buttons is updated correctly. "aria-pressed" attribute is set to "true" when button is pressed else it is "false".

Please find attached before and after patch screenshots.
RTBC

Looks like we're good on screenshots/videos and don't need any more of them in the issue.
I spotted some things in the test:

1. +++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
   @@ -42,10 +42,16 @@ public function testToolbarToggling() {
   +    $manage_link->getAttribute('aria-pressed');
   +    $this->assertEquals('true', $manage_link->getAttribute('aria-pressed'));
   

   Why is this getting the attribute without assigning it to a varianble and then getting it again in the assertEquals(). Seeme like the one line is that is needed.

2. +++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
   @@ -42,10 +42,16 @@ public function testToolbarToggling() {
   -    $page->clickLink('Manage');
   +    $manage_link->click();
   +    $this->assertEquals('false', $manage_link->getAttribute('aria-pressed'));
        $this->assertFalse($content->isVisible(), 'Toolbar tray is closed after clicking the "Manage" link.');
   -    $page->clickLink('Manage');
   +    $manage_link->click();
   +    $this->assertEquals('true', $manage_link->getAttribute('aria-pressed'));
   

   All of the checks for aria-pressed should have some sort of waitFor incorporated into it. In some instances a test may check for the attribute value before the JS has completed the change.

Marking this for https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Also including this reference.
https://www.accessibility-developer-guide.com/examples/sensible-aria-usa...

Removed tag Drupal 9 compatibility as D9 is EOL.

I created an MR against 11.x with patch #37 and the suggestions from #40.

Hiding patches as the fix is in an MR.

1) Drupal\Tests\toolbar\FunctionalJavascript\ToolbarIntegrationTest::testToolbarToggling
Failed asserting that false is true.
/builds/issue/drupal-3085781/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php:115
/builds/issue/drupal-3085781/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php:51
FAILURES!
Tests: 2, Assertions: 17, Failures: 1.

Shows the test coverage

Summary appears to match the fix of using attr

Believe this one is good

Committed and pushed 2f17d640524 to 11.x and dd94411ba01 to 11.1.x and 21bc1da3e70 to 10.5.x. Thanks!