If tablefield is added to a fieldable panel pane, users are not able to download a CSV file. Instead they see an access denied message. This patch fixes this by adding an access check for fieldable panel panes.

CommentFileSizeAuthor
#2 tablefield_access_check_fieldable_panel_panes-3067959-1.patch403 bytessquiggy

Comments

squiggy created an issue. See original summary.

squiggy’s picture

squiggy commented
StatusFileSize
new tablefield_access_check_fieldable_panel_panes-3067959-1.patch403 bytes
squiggy’s picture

squiggy commented
lolandese’s picture

lolandese commented
Category: Bug report » Feature request
Issue summary: View changes
Status: Active » Needs review

As there is a patch provided, I guess it needs review, thus changing status.

Providing support for other contrib modules is a Feature request, thus changing Category as well.

Thanks for the patch and reporting. Now the status is set it is more likely to be noticed by the other maintainers. I might get to test it soon.

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community 
martin@martin-XPS-13-9370 /var/www/html/yellow.localhost/web/sites/all/modules/contrib/tablefield (7.x-3.x=) $ git apply -v tablefield_access_check_fieldable_panel_panes-3067959-1.patch
Checking patch tablefield.module...
Applied patch tablefield.module cleanly.

The code makes sense. Because it is in an else condition this is pretty safe to commit without affecting non-panel pane entities.

  • lolandese committed d436635 on 7.x-3.x authored by squiggy 
    Issue #3067959 by squiggy: Include access check for...
lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.