Currently, the policy/constraint summary table shown to users is hard-coded in the policy validation helper function. This makes it impossible to customise in any meaningful way.

I propose creating a theme hook and template for the summary, to allow developers to customise the output of the validation data however they wish.

CommentFileSizeAuthor
#21 password_policy-3054412-21.patch3.92 KBmohammad-fayoumi
#17 password_policy-3054412-17.patch3.32 KBlamp5
#15 password_policy-3054412-15.patch3.32 KBjeroen_vreuls
#13 password_policy-3054412-13.patch2.56 KBanas_maw
#10 password_policy-3054412-9.patch3.45 KBlamp5
#9 password_policy-3054412-8.patch7.82 KBlamp5
#8 password_policy-3054412-7.patch7.05 KBlamp5
#6 3054412-6.patch7.34 KBrpayanm
#2 password_policy-summary_table_theming-3054412-2.patch7.93 KBmangy.fox

Issue fork password_policy-3054412

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mangy.fox created an issue. See original summary.

mangy.fox’s picture

mangy.fox commented
Assigned: mangy.fox » Unassigned
Status: Active » Needs review
StatusFileSize
new password_policy-summary_table_theming-3054412-2.patch7.93 KB

Supplied patch adds theme hook and template for the summary table. By default it outputs the table the same as it currently is to maintain backwards compatibility with existing styling.

Status: Needs review » Needs work

The last submitted patch, 2: password_policy-summary_table_theming-3054412-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mangy.fox’s picture

mangy.fox commented

As far as I can tell, the test failures are due to this issue https://www.drupal.org/project/password_policy/issues/3032549 and other deprecated code.

acrosman’s picture

acrosman
Primary language English
Location South Carolina, US
commented
Issue tags: +Needs reroll

A bit more flexibility here would be welcome, but looks like now that #303249: Local Menu setting active menu to undesirable menus has been committed (and perhaps others), the patch now needs a re-roll.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3054412-6.patch7.34 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3054412-6.patch, failed testing. View results

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-3054412-7.patch7.05 KB

@rpayanm your patch do not change the method of render policy summary table and additional breaks an ajax response.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new password_policy-3054412-8.patch7.82 KB

I forgot to add a template file to the patch.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new password_policy-3054412-9.patch3.45 KB

Reroll

Status: Needs review » Needs work

The last submitted patch, 10: password_policy-3054412-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

anas_maw’s picture

anas_maw commented

Great patch, working like a charm.
But please add {{ constraints_table }} as a default option in the template

anas_maw’s picture

anas_maw commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-3054412-13.patch2.56 KB

Actually the latest patch needs a minor fixes as it's not updating the constraint status, here is an updated one which will fix the issue.

Status: Needs review » Needs work

The last submitted patch, 13: password_policy-3054412-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jeroen_vreuls’s picture

jeroen_vreuls commented
StatusFileSize
new password_policy-3054412-15.patch3.32 KB

@Anas_maw
Your last patch is missing the template file, causing a fatal error when it is not in the theme. Attached patch has a default template.

anas_maw’s picture

anas_maw commented
Status: Needs work » Needs review

Oh, sorry for this miss. Thank you

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new password_policy-3054412-17.patch3.32 KB

Reroll to the latest dev.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3238787: Plan for Password Policy 8.x-3.1

Patch looks really good.
Thanks @lamp5.

paulocs opened merge request !17

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Created a MR so its easier to commit it.

mohammad-fayoumi’s picture

mohammad-fayoumi
Primary language English
Location Amman
commented
StatusFileSize
new password_policy-3054412-21.patch3.92 KB

I've tested the patch on the dev version and it works well, Thank you :)

But it didn't apply to the latest stable release 8.x-3.0, I've rerolled the patch to work on this version 8.x-3.0.

  • paulocs committed 782ab61 on 8.x-3.x 
    Issue #3054412 by lamp5, paulocs, mangy.fox, Anas_maw, jeroen_vreuls,...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented

Finally! :)

mangy.fox’s picture

mangy.fox commented

Amazing! Thanks everyone for running with this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol credited ultrabob.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Adding credit for similar work on another issue: #3129576: Guidance when there are no constraints enabled