MySQL DUPLICATE KEY error in trackItemInsert() function and a simple patch to fix

Dear Drupal guys,

We have an e-commerce powered by drupal. In admin users can import new products (which are node-based content-types) from Excel.

And after the new nodes were added, they should be indexed. While indexing the first imported node, we get the following error:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '25313-4' for key 'PRIMARY': INSERT INTO {search_api_item} (item_id, index_id, changed) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => 25313 [:db_insert_placeholder_1] => 4 [:db_insert_placeholder_2] => 1 ) in SearchApiAbstractDataSourceController->trackItemInsert() (line 626 of /path/to/drupal/sites/all/modules/search_api/includes/datasource.inc)

To fix the issue, I updated trackItemInsert() in sites/all/modules/search_api/includes/datasource.inc like so:

  /**
   * {@inheritdoc}
   */
  public function trackItemInsert(array $item_ids, array $indexes) {
    if (!$this->table || $item_ids === array()) {
      return;
    }

    foreach ($indexes as $index) {
      $this->checkIndex($index);
    }

    // Since large amounts of items can overstrain the database, only add items
    // in chunks.
    foreach (array_chunk($item_ids, 1000) as $chunk) {
      $insert = db_insert($this->table)
        ->fields(array($this->itemIdColumn, $this->indexIdColumn, $this->changedColumn));
      foreach ($chunk as $item_id) {
        foreach ($indexes as $index) {
          
          $duplicate_check_query = "SELECT COUNT(*) column_exists
            FROM {search_api_item}
            WHERE item_id = {$item_id}
            AND index_id = {$index->id}";
          $skip_insert = db_query($duplicate_check_query)->fetchField();

          if (!$skip_insert) {
            $insert->values(array(
            $this->itemIdColumn => $item_id,
            $this->indexIdColumn => $index->id,
            $this->changedColumn => 1,
            ));
          }
        }
      }
      $insert->execute();
    }
  }

I know the query is not 100% drupalized, but you get the idea. So I'm wondering if it can be a candidate for an update in search_api module.

To more easily see the update, I've attached my commit in gitlab.

Thank you,
Mohammad