Machine name field expands after failing validation

Added small fix for logic.
We will expand machine name, when value is not empty.

Where's the best admin page to test this on? I can't get a validation error on the node type create page, for instance, as leaving a form element blank produces a pop-up error.

Check gif in description of task. It's create vocabulary.

Ok, thanks.

I can confirm the patch fixes the issue.

+++ b/core/misc/machine-name.es6.js
@@ -46,10 +46,13 @@
+        // Let's expand machine name for edit only if we have not empty value.

I don't really understand the comment.

Also, the edit button this function handles disappears whenever the main name field is empty.

I think the correct fix would rather be to remove this call to clickEditHandler() further down:

$target.on('invalid', eventData, clickEditHandler);

That's calling the function that expands the machine name element whenever the main name field is invalid.

That's the source of this behaviour.

Though it does make me wonder whether this behaviour is by design, since there's code that very specifically does this. Git blame says:

commit 1a62e3c66dfe91d3dd24beb6828f28243ce856fd
Author: webchick <drupal@webchick.net>
Date:   Sun May 24 20:46:41 2015 -0700

    Issue #2488884 by pixelmord, tim.plunkett, droplet: Machine name HTML5 validation fails when field is hidden

So it sounds like #2488884: Machine name HTML5 validation fails when field is hidden should be examined for the reasons for this behaviour.

I guess, we can't just remove
$target.on('invalid', eventData, clickEditHandler);
User should have input of machine name, when machine name is "invalid" (for example, if name already exist).

I just added fix, wich change the logic
>> // Let's expand machine name for edit only if we have not empty value.
if "invalid" = empty, because user still not added name of vocabulary, we will don't show input for edit machine name.

I tested the patch for #4 and it worked fine.

I was hoping to test the patch for #8 but could not find it. Thanks.

This qualifies as a feature request I think. It also needs a reroll against 10.1.x

Attached patch against Drupal 10.1.x
Attached reroll patch
Removing the tag reroll

Didn't set things up for an interdiff, but the change was elminating the use of jQuery .val() per the eslint rules

Is this still addressing the same use case? It looks like the new approach in #22 would add stricter measures to when the machine name field should be invisible, rather than loosening those requirements. The use case in the issue summary seems to be that user clicks submit, but the form isn't actually submitted because of HTML 5 validation. This shouldn't result in the machine name field being revealed when the field for a human readable value is empty.

Verified MR!3406 and tested it on Drupal version 10.1.x. The patch works fine and I have added the before and after screen recordings for reference.

Merge request !3406 tested and applied clearly on drupal 10 version,
I have added some screenshots for references.

Thanks.

Posted review on the MR.

Appear to be 2 open threads in the MR 3406 if those can be looked at? @lauriii

Those threads should be addressed in the MR, marking back to NR.

Thanks @laurii for taking a look. Looks like there is 1 thread with an outstanding question.

There could be some crossover between this and #2662330: Machine name generation is way too slow, at least in so far as solution LOC intersection.

Confirmed with the MR the machine name doesn't appear for validation error.

Going to mark this but this may get sent back for issue summary update. proposed solution could be written out.

Updated issue summary. Also did a round of Screenreader/Keyboard Nav on HEAD vs this MR and confirmed there are no regressions with that experience.

Posted a question in the MR.

Tested locally and the fix still works. Ran the test "testMachineName" and it should still be green too

Can someone remove that require line from machine-name.js

Don't want to take myself out of the review role.

Change looks good and functions correctly.

Followed the steps of the issue summary.
Went to create a vocabulary
Clicked save (without filling anything in)
Machine name filed still does not appear.

Committed a650913 and pushed to 10.1.x. Thanks!