Consistent use of Milliseconds vs. Millisecs vs. ms [#303804]

Comment	File	Size	Author
#13	performance-fix-update-6001.patch	713 bytes	carlos8f

#11	performance-fix-update-7001.patch	1.25 KB	carlos8f

#6	ms.patch	16.58 KB	fgm

#4	ms.patch	0 bytes	fgm

#4	ms.patch	15.48 KB	fgm

#2	performance_ms.patch	14.59 KB	fgm

Comment #1

kbahey CreditAttribution: kbahey commented 20 October 2008 at 19:49

Project:	Performance Logging and Monitoring	» Devel
Version:	5.x-1.x-dev	» 6.x-1.x-dev
Component:	User interface	» performance

Moving to devel queue, since the module is now part of that.

Log in or register to post comments

Comment #2

fgm

French

Paris, France

CreditAttribution: fgm commented 9 October 2009 at 16:05

Status:

Active

» Needs review

File	Size
performance_ms.patch	14.59 KB

Suggested patch converts all to "ms", in both DB, APC, and reports.

Log in or register to post comments

Comment #3

kbahey CreditAttribution: kbahey commented 11 October 2009 at 15:55

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Needs review	» Patch (to be ported)

Thank you.

Committed to D6. Needs to be ported to D7.

Log in or register to post comments

Comment #4

fgm

French

Paris, France

CreditAttribution: fgm commented 25 December 2009 at 10:19

Status:

Patch (to be ported)

» Needs review

File	Size
ms.patch	15.48 KB

ms.patch	0 bytes

D7 version.

Log in or register to post comments

Comment #5

kbahey CreditAttribution: kbahey commented 25 December 2009 at 15:05

Status:

Needs review

» Needs work

Frederik,

Another big patch went in a few minutes ago and now this patch has some failed hunks.

Can you please re-roll against what is in HEAD CVS?

Log in or register to post comments

Comment #6

fgm

French

Paris, France

CreditAttribution: fgm commented 25 December 2009 at 17:21

Status:

Needs work

» Needs review

File	Size
ms.patch	16.58 KB

Yay, DBTNG ! One less on my to-do list :-)

New version.

Log in or register to post comments

Comment #7

kbahey CreditAttribution: kbahey commented 25 December 2009 at 17:40

Status:

Needs review

» Fixed

Committed to 7.x.

Thank you.

Log in or register to post comments

Comment #8

carlos8f CreditAttribution: carlos8f commented 25 December 2009 at 21:03

Status:

Fixed

» Active

This update failed for me, with a SQL syntax error. I'm not immediately sure why. Using latest D7 and devel HEAD.

Failed: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'm(m, m) unsigned NOT NULL auto_increment COMMENT 'm', ADD' at line 1

Log in or register to post comments

Comment #9

carlos8f CreditAttribution: carlos8f commented 25 December 2009 at 21:10

Also found this in the watchdog table:

Location
http://d7.7/update.php?op=start&id=2

Message	Warning: array_key_exists() expects parameter 2 to be array, string given in DatabaseSchema_mysql->createFieldSql() (line 128 of htdocs/includes/database/mysql/schema.inc).

Log in or register to post comments

Comment #10

kbahey CreditAttribution: kbahey commented 25 December 2009 at 21:22

Status:

Active

» Fixed

No, it is not this issue. It is #667788: DBTNG Performance module.

Log in or register to post comments

Comment #11

carlos8f CreditAttribution: carlos8f commented 25 December 2009 at 21:42

Status:

Fixed

» Reviewed & tested by the community

File	Size
performance-fix-update-7001.patch	1.25 KB

+++ performance/performance.install	25 Dec 2009 17:20:15 -0000
@@ -124,3 +125,23 @@ function performance_update_7001() {
+  if (!function_exists('apc_fetch')) {
+    apc_clear_cache('user');
+  }

Oops, fatal error from this too :( Attached patch fixes both of these.