We have to implement Dependency Injection in the FocalPointPreviewController.

I already implemented the DI and some minor code style fixes.
Will post the patch in the comment below.

CommentFileSizeAuthor
#3 di-for-preview-controller-3015267-3.patch5.84 KBNikolay Borisov
#2 di-for-preview-controller-3015267-2.patch6.19 KBNikolay Borisov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

flesheater created an issue. See original summary.

Nikolay Borisov’s picture

Nikolay Borisov CreditAttribution: Nikolay Borisov as a volunteer commented
FileSize
di-for-preview-controller-3015267-2.patch6.19 KB

Here is the patch that implements it.

Nikolay Borisov’s picture

Nikolay Borisov CreditAttribution: Nikolay Borisov as a volunteer commented
FileSize
di-for-preview-controller-3015267-3.patch5.84 KB

Sorry, this patch is better, since in the previous I forgot a test comment.

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented

Reviewed the code and this is a great improvement ... I havent had a chance to take it for a test drive yet, but so far so good

Nikolay Borisov’s picture

Nikolay Borisov CreditAttribution: Nikolay Borisov as a volunteer commented

Perfect, I am very glad :) Thanks for the review!

Cheers,
Nikolay

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Status: Needs review » Fixed

I committed this as two separate commits ... one for the dependency injection code and one for the coding standard fixes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.