Invalidate cache based on destination parameter and accept only paths as redirection values

Any ideas on how to solve it in Social Auth itself?

Thanks for the patch!

It works perfectly if the user is not logged in. However, when the user is logged in, the destination parameter is concatenated more than once.

I made some changes to make it work

I removed unnecessary wrapper

It could be resolved by:

1. disabling the cache on /user/login page, or
2. use front-end javascript to populate the destination parameter

I'm not sure that js solution is the correct way to resolve issue.

As possible case, it might be properly configured viewing element. As login_with is a theme with a preprocess you can add $variables['#cache']['max-age'] = 0; in the preprocess and it will disable caching for current element (themeing).

As advanced solution need to add cache dependency (cache context) by destination

As advanced solution need to add cache dependency (cache context) by destination

Any examples of how this solution would look like?

It would look something like the enclosed patch. :-)

I just noticed this patch also includes a cleanup of the handling of the destination parameter vis-a-vis the return to Drupal. If you are employing social auth as part of a chain-reaction of OAuth operations (e.g., OAuth Request is fulfilled after auth with a social provider) the query params in the destination string were kludged when generating a Url from the "base:" route.

I discovered this ticket via that fact pattern, and the cache issue effectively breaks destination handling for social auth, so I figure we can roll these together and have adjusted the ticket title as such.

#12 crashes the site on login. There are 3 errors in watchdog:

Failed to authenticate user. Exception: Cannot redirect to an empty URL.

LogicException: The controller must return a response (null given). Did you forget to add a return statement somewhere in your controller? in Symfony\Component\HttpKernel\HttpKernel->handleRaw() (line 169 of /vendor/symfony/http-kernel/HttpKernel.php).

InvalidArgumentException: Cannot redirect to an empty URL. in Symfony\Component\HttpFoundation\RedirectResponse->setTargetUrl() (line 86 of /vendor/symfony/http-foundation/RedirectResponse.php).

@adanielyan - Are you able to use xdebug to go in and see what might be causing this fact pattern? Alternatively, are you at DrupalCon this week and we could get together and look at it together?

Thanks, @bradjones1. I personally like avoiding a mix of markups with code as much as possible. I just added cache tags on the theme itself, so the cache gets invalidated after the destination parameter changes.

I liked the idea of just accepting paths. I think we shouldn't accept routes as possible destinations, though there were more changes needed to accomplish this fully.

Thanks, everyone!