Prototype currently depends on components.module, but the dependency is not defined in code. Installing prototype and creating a base theme without also first manually installing components causes a fatal error.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | correctly-handle-dependencie.patch | 704 bytes | b-ry |
Issue fork prototype-2964677
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
brentrobbins commentedHi Justin,
I am not sure if that functionality / capability is integrated into D8 (as of ver 8.6.1) core yet (themes having module dependancies). There is an issue that already discusses the possibility for 8.7-dev: https://www.drupal.org/node/474684
Brent
Comment #3
b-ry commentedHey,
Looks like there are a couple options.
1) A dependency can be added to the themes .info file which prevents the themes ability to be installed if the dependency is not meet.
i.e. dependencies
- drupal/components
2) Remove the Dependency on the module entirely and add a preprocess hook to do the same thing the module is doing.
Thoughts: if we don't rename the theme for each client it could be easier to just set it. Seems to be a bit more of an issue if the theme is renamed.
Comment #4
jldust commentedHi Bryon, thanks for taking a look into this. For the 2.x branch lets add it to the .info file as a dependency so that users can handle it at install and we don't structurally change the way the theme works.
Comment #6
b-ry commentedHey Jennifer, created a patch that adds the components dependency to the info file.
Comment #10
jldust commentedComment #11
jldust commentedThanks for making that patch, this has been merged in!