When sending test email and mail error appears(wrong smtp server... ), success message and error message are displayed simultaneously.See screenshot for more information.

CommentFileSizeAuthor
#6 2949012-6.patch1.1 KBravi.shankar
#4 Screen Shot 2018-03-14 at 09.16.43.png47.2 KBnkoporec
#4 Screen Shot 2018-03-14 at 09.20.15.png63.93 KBnkoporec
#3 smtp_fix_drupal_message-2949012_3.patch1.11 KBemartoni
#2 smtp_fix_form_drupal_messages.patch1.43 KBnkoporec
Screen Shot 2018-03-01 at 11.45.15.png96.74 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Active » Needs review
StatusFileSize
new smtp_fix_form_drupal_messages.patch1.43 KB

Created a patch, which shows the success message only when no mail errors appear.

emartoni’s picture

emartoni commented
StatusFileSize
new smtp_fix_drupal_message-2949012_3.patch1.11 KB

Hi @nkoporec, how are you?

Nice patch, but I think it's better to check the mail response instead get all the message and loop on it.
What do you think?

Best,
Eduardo

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
StatusFileSize
new Screen Shot 2018-03-14 at 09.20.15.png63.93 KB
new Screen Shot 2018-03-14 at 09.16.43.png47.2 KB

Hi @emartoni, yeah I would agree that is a more cleanly approach, but I tested your patch and the issue this exists ...The problem is that mail response is always true(I think it's because it takes some time to send the mail and the function always returns true at the beginning and when the error appears function executes the show error message) so the success message is displayed alongside the mail error message.See screenshot for more info.

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 2 year old patch in #3 no longer applies to 8.x-1.x-dev.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 2949012-6.patch1.1 KB

I have rerolled against 8.x-1.x-dev branch.

rivimey’s picture

rivimey
she/her
commented
Parent issue: » #3114671: Plan for SMTP 8.x-1.0 release
rivimey’s picture

rivimey
she/her
commented
Parent issue: #3114671: Plan for SMTP 8.x-1.0 release » #3081980: Plan for full 8.x-1.0 release of SMTP
wundo’s picture

wundo commented

  • wundo committed be819c9 on 8.x-1.x authored by ravi.shankar 
    Issue #2949012 by nkoporec, ravi.shankar, emartoni, rivimey, Chris...
wundo’s picture

wundo commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.