What are the steps required to reproduce the bug?

  1. Install a new Drupal 8.4 site and enable book module.
  2. Create a book
  3. Create 3 pages in this hierarhy: Page hierarhy structure
  4. Remove the parent element from the outline (on my image the Page 1)

What behavior were you expecting?
I think if you delete a parent, move the child one deph up. So it shoud be look like this:
Book
- Page 1.1
- Page 2

What happened instead?
Here are the images from the book (root) and the pages:
Book
Page 1
Page 2

But the page 1.1:
Page 1.1
Broken navigation, it's not under the book only from the current page, so deleted parent's child will be lost, and buggy.

CommentFileSizeAuthor
#16 drupal-missing_children-2945824-16.patch2.64 KBmatthijs
#9 drupal-missing_children-2945824-6-D8.patch2.63 KBabhishek-anand
#5 drupal-missing_children-2945824-5-D8.patch2.63 KBmohit_aghera
#2 drupal-missing_children-2945824-2-D8.patch1.23 KBgolddragon007
book.JPG23.86 KBgolddragon007
page-2.JPG20.74 KBgolddragon007
page-1-1.JPG28.72 KBgolddragon007
page-1.JPG16.84 KBgolddragon007
hierarhy.JPG11.08 KBgolddragon007

Issue fork book-2945824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

golddragon007 created an issue. See original summary.

golddragon007’s picture

golddragon007 commented
StatusFileSize
new drupal-missing_children-2945824-2-D8.patch1.23 KB

This patch will connect deleted parent's child with the parent's parent.

golddragon007’s picture

golddragon007 commented
Version: 8.4.x-dev » 8.6.x-dev
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Great catch! This is indeed behavior that's really unexpected. We should add tests for this to make sure we document the correct behavior.

mohit_aghera’s picture

mohit_aghera commented
Status: Needs work » Needs review
StatusFileSize
new drupal-missing_children-2945824-5-D8.patch2.63 KB

Adding method to test outline.
For now I am testing outline by adding one content to outline and then removing it's parent from outline.

Status: Needs review » Needs work

The last submitted patch, 5: drupal-missing_children-2945824-5-D8.patch, failed testing. View results

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

abhishek-anand’s picture

abhishek-anand commented
StatusFileSize
new drupal-missing_children-2945824-6-D8.patch2.63 KB

Rerolling the patch for Drupal 8.7

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

matthijs’s picture

matthijs
Primary language Dutch
commented
StatusFileSize
new drupal-missing_children-2945824-16.patch2.64 KB

Fixed usage of entityManager, which no longer exists in Drupal 9.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Postponed

This extension is being deprecated, see #3376070: [Meta] Tasks to deprecate Book module. It will be removed from core and moved to a contrib project, #3376101: [11.x] [Meta] Tasks to remove Book.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

This issue may be re-opened if it can be considered critical, If unsure, re-open the issue and ask in a comment.

smustgrave’s picture

smustgrave commented
Project: Drupal core » Book
Version: 11.x-dev » 1.0.x-dev
Component: book.module » Code
Status: Postponed » Needs work
smustgrave’s picture

smustgrave commented
Version: 1.0.x-dev » 2.0.x-dev

smustgrave opened merge request !50

  • smustgrave committed 610604d9 on 2.0.x 
    Issue #2945824 by golddragon007, mohit_aghera, abhishek-anand, matthijs...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed
Issue tags: -Needs tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.