Password policy and Password Reset Landing Page

Hello maintainers,

I'm the maintainer for Password Reset Landing Page (PRLP) module. The requester here had created the same issue in PRLP queue. But the issue can only be fixed in this module. Mainly, you have to implement hook_form_alter for $form_id == 'user_pass_reset', and also make sure the order of handlers is correct.

Please feel free to reach out to me for any changes I need to make to PRLP module in order to make your changes work.

Thanks --Jitesh

any luck with this? I have the same problem

I'm working on a patch for this issue.

I am trying to figure out a workaround here. Both modules are using hook_form_FORM_ID_alter(). As we read here: API hook_form_alter
"The call order is as follows: all existing form alter functions are called for module A, then all for module B, etc., followed by all for any base theme(s), and finally for the theme itself. The module order is determined by system weight, then by module name."

The PRLP module is latter than PASSWORD_POLICY module, as it is based in alphabetical order. (We suppose that we haven't alter the order by any way)

@Jitesh Doshi you propose to focus at hook_form_alter but calling the hook in password_policy module the $form doesn't have the password_confirmation field yet. The reason is the above about call order.

What may be the optimal way to approach this ?
Go to prlp module, check if password_policy is enabled and try to call password_policy module's functions ?
Make password_policy to be called latest (i don't know if it is supported by drupal) and make changes in it's hook ?

I think this will be fixed at this issue https://www.drupal.org/project/password_policy/issues/3078741

@vacho, I think it's better to keep the two issues separate. Let's deal with the prlp integration here.

++ to keep scope

NW for update hook to change weight

Update hook added.

Looks ready, thank you 👍

Applies cleanly to 3.x-dev, looks good-to-go.

-mike

I've reviewed and this seems fine. I have merged some other patches, can I get a reroll please?

Re-roll as requested. No interdiff, as there's no actual change other than context.

RTBC +1

This looks good as defined in #16 - ill merge this in and we can retest

Good to go! Thanks, all.