Problem/Motivation

I need to perform some Functional test Exception is raised: "No schema for ace_editor.settings".

#3401837: Add basic validation to config schema definitions

Faced issues with Recipes and simpleConfigUpdate action.
#3472383: Fix Varbase Editor Default Recipe to Import/Update Configs and Follow Schema with Configuration Inspector

doing something like the following in a recipe will not work

config:
  actions:
    ace_editor.settings:
      simpleConfigUpdate:
        theme: idle_fingers
        syntax: html
        height: auto
        width: '700px'
        font_size: '9pt'
        show_invisibles: false

Proposed resolution

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release ace_editor-2.0.1

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #2941227: Fixed missing install/schema to support configs with Recipes actions and pass Config Inspector validation
CommentFileSizeAuthor
#12 ace_editor-3455758-8--interdiff.patch1.1 KBmortona2k
#8 ace_editor-2941227-8.patch1.34 KBlamp5
#7 ace_editor-2941227-7.patch13.98 KBlamp5
#3 ace_editor-schema-2941227-D8.patch11.71 KBioana apetri

Issue fork ace_editor-2941227

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AndreaMaggi created an issue. See original summary.

ioana apetri’s picture

ioana apetri commented
Assigned: Unassigned » ioana apetri

Start to work on this issue.

ioana apetri’s picture

ioana apetri commented
Status: Active » Needs review
StatusFileSize
new ace_editor-schema-2941227-D8.patch11.71 KB

Here is the schema needed. Please review.

AndreaMaggi’s picture

AndreaMaggi commented

I've been busy with some other works. Now that I'm going to switch back to Drupal I will try your path and I will report to you. Thanks for now.

interdruper’s picture

interdruper commented
Status: Needs review » Needs work

Patch has errors in labels and it does not pass Config Inspector module checks.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Assigned: ioana apetri » lamp5
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Assigned: lamp5 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new ace_editor-2941227-7.patch13.98 KB
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new ace_editor-2941227-8.patch1.34 KB

Updated structure.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Missing install/schema » Fix Missing install/schema
Version: 8.x-1.x-dev » 2.0.x-dev
Priority: Normal » Major
Status: Needs review » Needs work
Issue tags: +config inspector

Needs an updated issue fork and MR for the 2.0.x branch.
Important issue to pass with config inspector

mortona2k made their first commit to this issue’s fork.

mortona2k opened merge request !13

mortona2k’s picture

mortona2k commented
Status: Needs work » Needs review
Related issues: +#3401837: Add basic validation to config schema definitions
StatusFileSize
new ace_editor-3455758-8--interdiff.patch1.1 KB

I fiddled with it until the errors went away.

Ended up flattening the schema a bit to make it work.

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
commented

the patch does not apply to the latest versions of the module
"ace_editor-3455758-8--interdiff.patch" is not a patch...
but, https://git.drupalcode.org/project/ace_editor/-/merge_requests/13.diff can be ues as patch ;-)

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix Missing install/schema » Fix missing install/schema to support configs with Recipes actions and pass Config Inspector validation
Component: Miscellaneous » Code
Issue summary: View changes
Issue tags: +Recipes initiative

Faced issues with Recipes and simpleConfigUpdate action.
#3472383: Fix Varbase Editor Default Recipe to Import/Update Configs and Follow Schema with Configuration Inspector

doing something like the following in a recipe will not work

config:
  actions:
    ace_editor.settings:
      simpleConfigUpdate:
        theme: idle_fingers
        syntax: html
        height: auto
        width: '700px'
        font_size: '9pt'
        show_invisibles: false
rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +Configuration schema

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

  • rajab natshah committed 9f3240eb on 2.0.x 
    Issue #2941227: Fix missing install/schema to support configs with...
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Issue tags: +ace_editor-2.0.1
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released ace_editor-2.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.