Deprecate, remove usages, add legacy tests for the following ImagemagickToolkit methods:

  • checkPath
  • getDestination
  • getDestinationFormat
  • getDestinationLocalPath
  • getPackage
  • getPackageLabel
  • getSourceFormat
  • getSourceLocalPath
  • setDestination
  • setDestinationFormat
  • setDestinationFormatFromExtension
  • setDestinationLocalPath
  • setSourceFormat
  • setSourceFormatFromExtension
  • setSourceLocalPath

Add the following methods:

  • ImagemagickToolkit::ensureSourceLocalPath
  • ImagemagickToolkit::getExecManager
  • ImagemagickExecManager::getFormatMapper
  • ImagemagickExecManager::getModuleHandler
  • ImagemagickExecArguments::setSourceFormatFromExtension
  • ImagemagickExecArguments::setDestinationFormatFromExtension
CommentFileSizeAuthor
#8 interdiff_6-8.txt2.57 KBmondrake
#8 2938375-8.patch55.54 KBmondrake
#6 2938375-6.patch54.9 KBmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Assigned: Unassigned » ioana apetri

I start working on this.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Assigned: ioana apetri » mondrake

@yo30 please don't, I'm already almost there - https://github.com/mondrake/imagemagick/pull/21

Sorry!

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

@yo30 would you consider working on #2938377: Deprecate parsing source image with getimagesize instead?

Thanks!

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented

Ohh ok, not a problem.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2938375-6.patch54.9 KB

Here's the patch. Deprecates, removes usages, adds legacy tests for the methods deprecated in the IS.

Status: Needs review » Needs work

The last submitted patch, 6: 2938375-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
FileSize
2938375-8.patch55.54 KB
interdiff_6-8.txt2.57 KB

The testSourceLocalPath test now requires actual binaries to execute.

  • mondrake authored 97d61fc on 8.x-2.x 
    Issue #2938375 by mondrake: Deprecate in ImagemagickToolkit all methods...
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue summary: View changes

Committed.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Fixed
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue tags: +release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.