I want to simplify the editorial experience of my website so people only have to chose the view they want to render and since I leave only one block display to chose I don't want to bother them with that useless choice.

CommentFileSizeAuthor
#8 hide-display-2932381-8.patch3.01 KBpurushotam.rai
#7 hide-display-2932381-7.patch2.83 KBpurushotam.rai
#2 2932381-hide-display-for-one-choice-2.patch2.21 KBrodrigoaguilera

Issue fork viewsreference-2932381

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rodrigoaguilera created an issue. See original summary.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Active » Needs review
StatusFileSize
new 2932381-hide-display-for-one-choice-2.patch2.21 KB

Here is a patch that does exactly that.

I did a small coding standard fix and made the message that is shown when there is no displays translatable.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Needs work

I coworker tried the patch and reported that is not working with fields inside paragraphs. I did not test that use case so that needs to be fixed

purushotam.rai made their first commit to this issue’s fork.

purushotam.rai opened merge request !20

purushotam.rai’s picture

purushotam.rai commented
Status: Needs work » Needs review
purushotam.rai’s picture

purushotam.rai commented
StatusFileSize
new hide-display-2932381-7.patch2.83 KB
purushotam.rai’s picture

purushotam.rai commented
StatusFileSize
new hide-display-2932381-8.patch3.01 KB

We have to update default display_id in itemResetValues as well. It was creating a issue, hence updated the patch.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented

Marked #3166491: Hide view display element if there is only one display as duplicate.

sassafrass’s picture

sassafrass commented

Applied the latest patch and it hides a single Display as expected. However, I was wondering if it also makes sense to hide the View selection if there is only one View as well? Or to give users the option to hide those fields?

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented
Status: Needs review » Needs work

See my comment on the MR + now that we have tests, the tests assume the default behaviour, so we should update the test coverage to cover a View with 2+ displays and a View with only 1 display.

scott_euser’s picture

scott_euser commented
Status: Needs work » Fixed

Added tests myself rather than let this sit another 8 years :) Thanks all for the help!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

scott_euser changed the visibility of the branch 2932381-hide-display-id-regression to hidden.

scott_euser changed the visibility of the branch 2932381-hide-display-id-regression to active.

scott_euser opened merge request !103

  • scott_euser committed c78f3181 on 8.x-2.x 
    fix: #2932381 Resolve regression for "Hide the choice for a view display...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.