Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I added a product to cart and went to the checkout page. I have not created a payment gateway and therefore I get drupal message -
No payment gateways are defined, create one first.
I think it will be nice if we get the link to create a payment gateway also in the link.
Thanks
Comment | File | Size | Author |
---|---|---|---|
#18 | 2927114-18.patch | 3.52 KB | mglaman |
| |||
#17 | 2927114-17.patch | 3.32 KB | mglaman |
| |||
#15 | 2927114-15.patch | 1.1 KB | sorabh.v6 |
| |||
#15 | 2927114-15-interdiff.txt | 775 bytes | sorabh.v6 |
#12 | 2927114-12.patch | 1.09 KB | sorabh.v6 |
Comments
Comment #2
sorabh.v6Patch is uploaded with the code to print the link of the add payment gateway in the drupal message. Please review.
Thanks
Comment #3
heddnLooks good to me.
Comment #4
vdenis CreditAttribution: vdenis commentedI've tested the patch and it looks good for me too.
Comment #5
bojanz CreditAttribution: bojanz at Centarro commented#2917372: incorrect use of translation in CartEventSubscriber tells us that this is the wrong way to do a link inside t(). Let's follow its suggestion.
Comment #6
sorabh.v6Comment #7
sorabh.v6Hi,
Code updated, please review the updated patch.
Thanks
Comment #8
sorabh.v6Wrong patch file update in the previous comment. This comment has the correct patchfile.
Thanks
Comment #10
heddnGood feedback in #5. This looks good to go now.
Comment #11
bojanz CreditAttribution: bojanz at Centarro commentedCore uses : instead of @ for urls.
Comment #12
sorabh.v6Changes made as suggested in #11. Please review the updated patch.
Comment #14
drugan CreditAttribution: drugan as a volunteer commentedMay be test is failed because you should do this instead of the latest changes:
Comment #15
sorabh.v6Thanks @drugan. Code updated as suggested in #14. Please review.
Comment #16
mglamanWe need test coverage in a Functional test.
Comment #17
mglamanMy local is screwing up, here's a pass at a test.
Comment #18
mglamanWhoops, forgot the admin permission.
Comment #19
mglamanbojanz: thoughts? I wasn't sure at first since it links to admin. But I highly doubt someone will launch like this :) And it improves the developer/site builder experience.
Comment #20
bojanz CreditAttribution: bojanz at Centarro commentedDiscussed points:
1) We might have gateways, but none of their conditions passed. "available" is the word we want to use, not "defined".
2) We need to account for the user possibly not having permissions to manage gateways (hence, we need two different messages).
Comment #21
bojanz CreditAttribution: bojanz at Centarro commentedComment #23
bojanz CreditAttribution: bojanz at Centarro commentedTweaked as discussed and committed. Thanks, everyone.